* [PATCH v2 1/2] ARM: mvebu: use armada-370-sata for SATA on Armada 375
@ 2016-02-10 16:29 Thomas Petazzoni
2016-02-10 17:17 ` Andrew Lunn
2016-02-12 16:49 ` Gregory CLEMENT
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2016-02-10 16:29 UTC (permalink / raw)
To: Jason Cooper, Andrew Lunn, Sebastian Hesselbarth, Gregory Clement
Cc: Nadav Haklai, Lior Amsalem, linux-arm-kernel, stable,
Thomas Petazzoni
From: Lior Amsalem <alior@marvell.com>
The Armada 375 has the same SATA IP as Armada 370 and Armada XP, which
requires the PHY speed to be set in the LP_PHY_CTL register for SATA
hotplug to work.
Therefore, this commit updates the compatible string used to describe
the SATA IP in Armada 375 from marvell,orion-sata to
marvell,armada-370-sata.
Fixes: 4de59085091f753d08c8429d756b46756ab94665 ("ARM: mvebu: add Device Tree description of the Armada 375 SoC")
Cc: <stable@vger.kernel.org>
Signed-off-by: Lior Amsalem <alior@marvell.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
Changes since v1:
- Add Fixes: tag, and add stable@ in Cc, as suggested by Andrew Lunn.
---
arch/arm/boot/dts/armada-375.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/armada-375.dtsi b/arch/arm/boot/dts/armada-375.dtsi
index 7ccce75..cc952cf 100644
--- a/arch/arm/boot/dts/armada-375.dtsi
+++ b/arch/arm/boot/dts/armada-375.dtsi
@@ -529,7 +529,7 @@
};
sata@a0000 {
- compatible = "marvell,orion-sata";
+ compatible = "marvell,armada-370-sata";
reg = <0xa0000 0x5000>;
interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&gateclk 14>, <&gateclk 20>;
--
2.6.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/2] ARM: mvebu: use armada-370-sata for SATA on Armada 375
2016-02-10 16:29 [PATCH v2 1/2] ARM: mvebu: use armada-370-sata for SATA on Armada 375 Thomas Petazzoni
@ 2016-02-10 17:17 ` Andrew Lunn
2016-02-12 16:49 ` Gregory CLEMENT
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2016-02-10 17:17 UTC (permalink / raw)
To: Thomas Petazzoni
Cc: Jason Cooper, Sebastian Hesselbarth, Gregory Clement,
Nadav Haklai, Lior Amsalem, linux-arm-kernel, stable
On Wed, Feb 10, 2016 at 05:29:15PM +0100, Thomas Petazzoni wrote:
> From: Lior Amsalem <alior@marvell.com>
>
> The Armada 375 has the same SATA IP as Armada 370 and Armada XP, which
> requires the PHY speed to be set in the LP_PHY_CTL register for SATA
> hotplug to work.
>
> Therefore, this commit updates the compatible string used to describe
> the SATA IP in Armada 375 from marvell,orion-sata to
> marvell,armada-370-sata.
>
> Fixes: 4de59085091f753d08c8429d756b46756ab94665 ("ARM: mvebu: add Device Tree description of the Armada 375 SoC")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Lior Amsalem <alior@marvell.com>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Thanks for adding the tags,
Andrew
> ---
> Changes since v1:
> - Add Fixes: tag, and add stable@ in Cc, as suggested by Andrew Lunn.
> ---
> arch/arm/boot/dts/armada-375.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/armada-375.dtsi b/arch/arm/boot/dts/armada-375.dtsi
> index 7ccce75..cc952cf 100644
> --- a/arch/arm/boot/dts/armada-375.dtsi
> +++ b/arch/arm/boot/dts/armada-375.dtsi
> @@ -529,7 +529,7 @@
> };
>
> sata@a0000 {
> - compatible = "marvell,orion-sata";
> + compatible = "marvell,armada-370-sata";
> reg = <0xa0000 0x5000>;
> interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&gateclk 14>, <&gateclk 20>;
> --
> 2.6.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/2] ARM: mvebu: use armada-370-sata for SATA on Armada 375
2016-02-10 16:29 [PATCH v2 1/2] ARM: mvebu: use armada-370-sata for SATA on Armada 375 Thomas Petazzoni
2016-02-10 17:17 ` Andrew Lunn
@ 2016-02-12 16:49 ` Gregory CLEMENT
1 sibling, 0 replies; 3+ messages in thread
From: Gregory CLEMENT @ 2016-02-12 16:49 UTC (permalink / raw)
To: Thomas Petazzoni
Cc: Jason Cooper, Andrew Lunn, Sebastian Hesselbarth, Nadav Haklai,
Lior Amsalem, linux-arm-kernel, stable
Hi Thomas,
On mer., févr. 10 2016, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:
> From: Lior Amsalem <alior@marvell.com>
>
> The Armada 375 has the same SATA IP as Armada 370 and Armada XP, which
> requires the PHY speed to be set in the LP_PHY_CTL register for SATA
> hotplug to work.
>
> Therefore, this commit updates the compatible string used to describe
> the SATA IP in Armada 375 from marvell,orion-sata to
> marvell,armada-370-sata.
>
> Fixes: 4de59085091f753d08c8429d756b46756ab94665 ("ARM: mvebu: add Device Tree description of the Armada 375 SoC")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Lior Amsalem <alior@marvell.com>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Applied on mvebu/dt, I renamed the patch to: " ARM: dts: armada-375: use
armada-370-sata for SATA" to unify the way we labl the dt related patch.
I also adde the reviwed-by tag from Andrew.
Thanks,
Gregory
> ---
> Changes since v1:
> - Add Fixes: tag, and add stable@ in Cc, as suggested by Andrew Lunn.
> ---
> arch/arm/boot/dts/armada-375.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/armada-375.dtsi b/arch/arm/boot/dts/armada-375.dtsi
> index 7ccce75..cc952cf 100644
> --- a/arch/arm/boot/dts/armada-375.dtsi
> +++ b/arch/arm/boot/dts/armada-375.dtsi
> @@ -529,7 +529,7 @@
> };
>
> sata@a0000 {
> - compatible = "marvell,orion-sata";
> + compatible = "marvell,armada-370-sata";
> reg = <0xa0000 0x5000>;
> interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&gateclk 14>, <&gateclk 20>;
> --
> 2.6.4
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-12 16:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-10 16:29 [PATCH v2 1/2] ARM: mvebu: use armada-370-sata for SATA on Armada 375 Thomas Petazzoni
2016-02-10 17:17 ` Andrew Lunn
2016-02-12 16:49 ` Gregory CLEMENT
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).