From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f43.google.com ([209.85.220.43]:35586 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750773AbcBLGdX (ORCPT ); Fri, 12 Feb 2016 01:33:23 -0500 Received: by mail-pa0-f43.google.com with SMTP id ho8so42039305pac.2 for ; Thu, 11 Feb 2016 22:33:23 -0800 (PST) Date: Fri, 12 Feb 2016 12:03:20 +0530 From: Viresh Kumar To: Andy Shevchenko Cc: Vinod Koul , dmaengine@vger.kernel.org, Mans Rullgard , stable@vger.kernel.org Subject: Re: [PATCH v1 1/1] dmaengine: dw: disable BLOCK IRQs for non-cyclic xfer Message-ID: <20160212063320.GF16949@vireshk-i7> References: <1455112782-75078-1-git-send-email-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1455112782-75078-1-git-send-email-andriy.shevchenko@linux.intel.com> Sender: stable-owner@vger.kernel.org List-ID: On 10-02-16, 15:59, Andy Shevchenko wrote: > The commit 2895b2cad6e7 ("dmaengine: dw: fix cyclic transfer callbacks") > re-enabled BLOCK interrupts with regard to make cyclic transfers work. However, > this change becomes a regression for non-cyclic transfers as interrupt counters > under stress test had been grown enormously (approximately per 4-5 bytes in the > UART loop back test). > > Taking into consideration above enable BLOCK interrupts if and only if channel > is programmed to perform cyclic transfer. > > Fixes: 2895b2cad6e7 ("dmaengine: dw: fix cyclic transfer callbacks") > Signed-off-by: Andy Shevchenko > Cc: Mans Rullgard > Cc: Viresh Kumar > Cc: > --- > drivers/dma/dw/core.c | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) Acked-by: Viresh Kumar -- viresh