From: Willy Tarreau <w@1wt.eu>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: stable@vger.kernel.org
Subject: Re: [PATCH 2.6.32-3.14] pipe: Fix buffer offset after partially failed read
Date: Sun, 14 Feb 2016 07:47:33 +0100 [thread overview]
Message-ID: <20160214064733.GA28560@1wt.eu> (raw)
In-Reply-To: <20160213184225.GA5231@decadent.org.uk>
On Sat, Feb 13, 2016 at 06:42:26PM +0000, Ben Hutchings wrote:
> Quoting the RHEL advisory:
>
> > It was found that the fix for CVE-2015-1805 incorrectly kept buffer
> > offset and buffer length in sync on a failed atomic read, potentially
> > resulting in a pipe buffer state corruption. A local, unprivileged user
> > could use this flaw to crash the system or leak kernel memory to user
> > space. (CVE-2016-0774, Moderate)
>
> The same flawed fix was applied to stable branches from 2.6.32.y to
> 3.14.y inclusive, and I was able to reproduce the issue on 3.2.y.
> We need to give pipe_iov_copy_to_user() a separate offset variable
> and only update the buffer offset if it succeeds.
Queued for last 2.6.32, thanks Ben!
Willy
next prev parent reply other threads:[~2016-02-14 6:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-13 18:42 [PATCH 2.6.32-3.14] pipe: Fix buffer offset after partially failed read Ben Hutchings
2016-02-14 6:47 ` Willy Tarreau [this message]
2016-02-15 15:12 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160214064733.GA28560@1wt.eu \
--to=w@1wt.eu \
--cc=ben@decadent.org.uk \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).