From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com ([192.55.52.88]:60060 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751635AbcBOQr1 (ORCPT ); Mon, 15 Feb 2016 11:47:27 -0500 Date: Mon, 15 Feb 2016 22:21:02 +0530 From: Vinod Koul To: Andy Shevchenko Cc: dmaengine@vger.kernel.org, Mans Rullgard , Viresh Kumar , stable@vger.kernel.org Subject: Re: [PATCH v1 1/1] dmaengine: dw: disable BLOCK IRQs for non-cyclic xfer Message-ID: <20160215165102.GK19598@localhost> References: <1455112782-75078-1-git-send-email-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1455112782-75078-1-git-send-email-andriy.shevchenko@linux.intel.com> Sender: stable-owner@vger.kernel.org List-ID: On Wed, Feb 10, 2016 at 03:59:42PM +0200, Andy Shevchenko wrote: > The commit 2895b2cad6e7 ("dmaengine: dw: fix cyclic transfer callbacks") > re-enabled BLOCK interrupts with regard to make cyclic transfers work. However, > this change becomes a regression for non-cyclic transfers as interrupt counters > under stress test had been grown enormously (approximately per 4-5 bytes in the > UART loop back test). > > Taking into consideration above enable BLOCK interrupts if and only if channel > is programmed to perform cyclic transfer. Applied, thanks -- ~Vinod