From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com ([74.125.82.42]:36341 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932466AbcBPOXI (ORCPT ); Tue, 16 Feb 2016 09:23:08 -0500 Received: by mail-wm0-f42.google.com with SMTP id g62so109990525wme.1 for ; Tue, 16 Feb 2016 06:23:07 -0800 (PST) Date: Tue, 16 Feb 2016 15:23:33 +0100 From: Daniel Vetter To: Gerd Hoffmann Cc: David Airlie , Daniel Vetter , stable@vger.kernel.org, gnomes@lxorguk.ukuu.org.uk, "open list:DRM DRIVERS" , open list Subject: Re: [PATCH v2] qxl: use kmalloc_array to alloc reloc_info in qxl_process_single_command Message-ID: <20160216142333.GD32705@phenom.ffwll.local> References: <1455629100-4392-1-git-send-email-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1455629100-4392-1-git-send-email-kraxel@redhat.com> Sender: stable-owner@vger.kernel.org List-ID: On Tue, Feb 16, 2016 at 02:25:00PM +0100, Gerd Hoffmann wrote: > This avoids integer overflows on 32bit machines when calculating > reloc_info size, as reported by Alan Cox. > > Cc: stable@vger.kernel.org > Cc: gnomes@lxorguk.ukuu.org.uk > Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/qxl/qxl_ioctl.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/qxl/qxl_ioctl.c b/drivers/gpu/drm/qxl/qxl_ioctl.c > index 2ae8577..7c2e782 100644 > --- a/drivers/gpu/drm/qxl/qxl_ioctl.c > +++ b/drivers/gpu/drm/qxl/qxl_ioctl.c > @@ -168,7 +168,8 @@ static int qxl_process_single_command(struct qxl_device *qdev, > cmd->command_size)) > return -EFAULT; > > - reloc_info = kmalloc(sizeof(struct qxl_reloc_info) * cmd->relocs_num, GFP_KERNEL); > + reloc_info = kmalloc_array(cmd->relocs_num, > + sizeof(struct qxl_reloc_info), GFP_KERNEL); > if (!reloc_info) > return -ENOMEM; > > -- > 1.8.3.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch