* [PATCH] hwmon: (ads1015) Handle negative conversion values correctly
@ 2016-02-18 13:07 Peter Rosin
2016-02-19 22:26 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Peter Rosin @ 2016-02-18 13:07 UTC (permalink / raw)
To: Dirk Eibach
Cc: Peter Rosin, Jean Delvare, Guenter Roeck, lm-sensors,
linux-kernel, stable, Peter Rosin
From: Peter Rosin <peda@axentia.se>
Make the divisor signed as DIV_ROUND_CLOSEST is undefined for negative
dividends when the divisor is unsigned.
Signed-off-by: Peter Rosin <peda@axentia.se>
---
drivers/hwmon/ads1015.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/ads1015.c b/drivers/hwmon/ads1015.c
index f155b8380481..2b3105c8aed3 100644
--- a/drivers/hwmon/ads1015.c
+++ b/drivers/hwmon/ads1015.c
@@ -126,7 +126,7 @@ static int ads1015_reg_to_mv(struct i2c_client *client, unsigned int channel,
struct ads1015_data *data = i2c_get_clientdata(client);
unsigned int pga = data->channel_data[channel].pga;
int fullscale = fullscale_table[pga];
- const unsigned mask = data->id == ads1115 ? 0x7fff : 0x7ff0;
+ const int mask = data->id == ads1115 ? 0x7fff : 0x7ff0;
return DIV_ROUND_CLOSEST(reg * fullscale, mask);
}
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hwmon: (ads1015) Handle negative conversion values correctly
2016-02-18 13:07 [PATCH] hwmon: (ads1015) Handle negative conversion values correctly Peter Rosin
@ 2016-02-19 22:26 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2016-02-19 22:26 UTC (permalink / raw)
To: Peter Rosin
Cc: Dirk Eibach, Peter Rosin, Jean Delvare, Guenter Roeck, lm-sensors,
linux-kernel, stable
On Thu, Feb 18, 2016 at 02:07:52PM +0100, Peter Rosin wrote:
> From: Peter Rosin <peda@axentia.se>
>
> Make the divisor signed as DIV_ROUND_CLOSEST is undefined for negative
> dividends when the divisor is unsigned.
>
> Signed-off-by: Peter Rosin <peda@axentia.se>
> ---
> drivers/hwmon/ads1015.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read Documentation/stable_kernel_rules.txt
for how to do this properly.
</formletter>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-19 22:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-18 13:07 [PATCH] hwmon: (ads1015) Handle negative conversion values correctly Peter Rosin
2016-02-19 22:26 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).