From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([198.137.202.9]:34242 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753010AbcBVI7m (ORCPT ); Mon, 22 Feb 2016 03:59:42 -0500 Date: Mon, 22 Feb 2016 00:59:40 -0800 From: Christoph Hellwig To: Ming Lei Cc: Jens Axboe , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Christoph Hellwig , Sagi Grimberg , Kent Overstreet , Keith Busch , Elliott Robert , stable@vger.kernel.org Subject: Re: [PATCH v1 1/4] block: bio: introduce helpers to get the 1st and last bvec Message-ID: <20160222085940.GA4597@infradead.org> References: <1455852022-14188-1-git-send-email-ming.lei@canonical.com> <1455852022-14188-2-git-send-email-ming.lei@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1455852022-14188-2-git-send-email-ming.lei@canonical.com> Sender: stable-owner@vger.kernel.org List-ID: > +/* > + * bio_get_last_bvec() is introduced to get the last bvec of one > + * bio for bio_will_gap(). > + */ I don't think this comment adds any value. Otherwise looks fine: Reviewed-by: Christoph Hellwig