From: David Miller <davem@davemloft.net>
To: bernie.harris@alliedtelesis.co.nz
Cc: netdev@vger.kernel.org, kuznet@ms2.inr.ac.ru, stable@vger.kernel.org
Subject: Re: [PATCH v3] tunnel: Clear IPCB(skb)->opt before dst_link_failure called
Date: Tue, 23 Feb 2016 19:12:21 -0500 (EST) [thread overview]
Message-ID: <20160223.191221.211549664974307758.davem@davemloft.net> (raw)
In-Reply-To: <1456099085-24097-1-git-send-email-bernie.harris@alliedtelesis.co.nz>
From: Bernie Harris <bernie.harris@alliedtelesis.co.nz>
Date: Mon, 22 Feb 2016 12:58:05 +1300
> IPCB may contain data from previous layers (in the observed case the
> qdisc layer). In the observed scenario, the data was misinterpreted as
> ip header options, which later caused the ihl to be set to an invalid
> value (<5). This resulted in an infinite loop in the mips implementation
> of ip_fast_csum.
>
> This patch clears IPCB(skb)->opt before dst_link_failure can be called for
> various types of tunnels. This change only applies to encapsulated ipv4
> packets.
>
> The code introduced in 11c21a30 which clears all of IPCB has been removed
> to be consistent with these changes, and instead the opt field is cleared
> unconditionally in ip_tunnel_xmit. The change in ip_tunnel_xmit applies to
> SIT, GRE, and IPIP tunnels.
>
> The relevant vti, l2tp, and pptp functions already contain similar code for
> clearing the IPCB.
>
> Signed-off-by: Bernie Harris <bernie.harris@alliedtelesis.co.nz>
Applied and queued up for -stable, thanks!
next prev parent reply other threads:[~2016-02-24 0:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 4:07 [PATCH] ip6_gre: clear IPCB in ip6gre_xmit2 in case dst_link_failure called Bernie Harris
2016-02-16 1:10 ` [PATCH v2] gre: Avoid kernel panic by clearing IPCB before " Bernie Harris
2016-02-17 21:31 ` David Miller
2016-02-22 4:57 ` Bernie Harris
2016-02-21 23:24 ` Bernie Harris
2016-02-21 23:24 ` [PATCH v3] tunnel: Clear IPCB(skb)->opt before dst_link_failure called Bernie Harris
2016-02-21 23:58 ` Bernie Harris
2016-02-24 0:12 ` David Miller [this message]
2016-02-17 15:26 ` [PATCH] ip6_gre: clear IPCB in ip6gre_xmit2 in case " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160223.191221.211549664974307758.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bernie.harris@alliedtelesis.co.nz \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).