From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Alex Williamson <alex.williamson@redhat.com>,
Baptiste Reynal <b.reynal@virtualopensystems.com>,
Eric Auger <eric.auger@linaro.org>,
Antonios Motakis <a.motakis@virtualopensystems.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
kvm@vger.kernel.org
Subject: Re: [PATCH for-4.5] vfio: fix ioctl error handling
Date: Fri, 26 Feb 2016 16:47:48 +0300 [thread overview]
Message-ID: <20160226134748.GL5273@mwanda> (raw)
In-Reply-To: <1456399902-7352-1-git-send-email-mst@redhat.com>
On Thu, Feb 25, 2016 at 01:34:43PM +0200, Michael S. Tsirkin wrote:
> Calling return copy_to_user(...) in an ioctl will not
> do the right thing if there's a pagefault:
> copy_to_user returns the number of bytes not copied
> in this case.
>
> Fix up vfio to do
> if (copy_to_user(...))
> return -EFAULT;
>
> everywhere.
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Heh. I don't exactly deserve this credit.
I have updated Smatch to check for this (will push next week probably).
I wouldn't have caught the issues in vfio_platform_common.c because
that's ARM only.
regards,
dan carpenter
next prev parent reply other threads:[~2016-02-26 13:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 11:34 [PATCH for-4.5] vfio: fix ioctl error handling Michael S. Tsirkin
2016-02-26 13:47 ` Dan Carpenter [this message]
2016-02-28 13:23 ` Alex Williamson
2016-02-28 14:10 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160226134748.GL5273@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Julia.Lawall@lip6.fr \
--cc=a.motakis@virtualopensystems.com \
--cc=alex.williamson@redhat.com \
--cc=b.reynal@virtualopensystems.com \
--cc=eric.auger@linaro.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).