From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e23smtp04.au.ibm.com ([202.81.31.146]:45355 "EHLO e23smtp04.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750763AbcCABQP (ORCPT ); Mon, 29 Feb 2016 20:16:15 -0500 Received: from localhost by e23smtp04.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 1 Mar 2016 11:16:12 +1000 Received: from d23relay08.au.ibm.com (d23relay08.au.ibm.com [9.185.71.33]) by d23dlp02.au.ibm.com (Postfix) with ESMTP id 9EFED2BB0054 for ; Tue, 1 Mar 2016 12:16:01 +1100 (EST) Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay08.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u211FrHv31523070 for ; Tue, 1 Mar 2016 12:16:01 +1100 Received: from d23av03.au.ibm.com (localhost [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u211FSrF005094 for ; Tue, 1 Mar 2016 12:15:29 +1100 Date: Tue, 1 Mar 2016 12:14:33 +1100 From: Gavin Shan To: Sasha Levin Cc: Guenter Roeck , stable , Youngmin Nam , Gavin Shan , Alan Cox Subject: Re: Build errors in v3.18-stable-queue Message-ID: <20160301011433.GA23235@gwshan> Reply-To: Gavin Shan References: <56D2CFB3.1060202@roeck-us.net> <56D4E141.5000100@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56D4E141.5000100@oracle.com> Sender: stable-owner@vger.kernel.org List-ID: On Mon, Feb 29, 2016 at 07:24:33PM -0500, Sasha Levin wrote: >On 02/28/2016 05:45 AM, Guenter Roeck wrote: >> Current build results: >> total: 137 pass: 121 fail: 16 >> Failed builds: >> arm:allmodconfig >> arm:omap2plus_defconfig >> arm:exynos_defconfig >> arm:s5pv210_defconfig >> powerpc:defconfig >> powerpc:allmodconfig >> powerpc:allnoconfig >> powerpc:ppc64e_defconfig >> powerpc:cell_defconfig >> powerpc:maple_defconfig >> powerpc:ppc6xx_defconfig >> powerpc:mpc83xx_defconfig >> powerpc:tqm8xx_defconfig >> powerpc:85xx/sbc8548_defconfig >> powerpc:83xx/mpc834x_mds_defconfig >> powerpc:86xx/sbc8641d_defconfig >> >> Culprits are listed below. Copying the patch authors for advice. >> Thanks for reporting it, Guenter. some questions as below: - The subject says you were building 3.18 stable kernel, but the PowerPC related commit was merged to 4.1 kernel. So I assume you were building 4.1 stable kernel instead. - All above PowerPC configuration failed to build? At least, those configuration that has (CONFIG_PPC64=y) shouldn't fail because of the error you pointed. - Those configuration without (CONFIG_PPC64=y) needs below fix. Could you please have a try? If it works, I'll post a patch as soon as possible. diff --git a/arch/powerpc/kernel/of_platform.c b/arch/powerpc/kernel/of_platform.c index b60a67d..25dec0b 100644 --- a/arch/powerpc/kernel/of_platform.c +++ b/arch/powerpc/kernel/of_platform.c @@ -71,8 +71,10 @@ static int of_pci_phb_probe(struct platform_device *dev) eeh_dev_phb_init_dynamic(phb); /* Register devices with EEH */ +#ifdef CONFIG_EEH if (dev->dev.of_node->child) eeh_add_device_tree_early(PCI_DN(dev->dev.of_node)); +#endif Thanks, Gavin >> Guenter >> >> --- >> powerpc: >> >> In file included from arch/powerpc/kernel/of_platform.c:30:0: >> ./arch/powerpc/include/asm/eeh.h:344:48: error: 'struct pci_dn' declared inside parameter list >> >> Culprit: "powerpc/eeh: Do probe on pci_dn" >> >> --- >> arm: >> >> drivers/pinctrl/samsung/pinctrl-samsung.c: In function 'samsung_gpio_set': >> drivers/pinctrl/samsung/pinctrl-samsung.c:551:9: error: implicit declaration of function 'gpiochip_get_data' >> >> Culprit: "pinctrl: samsung: fix SMP race condition" >> >> drivers/tty/serial/omap-serial.c: In function 'serial_omap_stop_tx': >> drivers/tty/serial/omap-serial.c:318:10: error: 'struct uart_port' has no member named 'rs485' >> >> drivers/tty/serial/omap-serial.c: In function 'serial_omap_probe': >> drivers/tty/serial/omap-serial.c:1683:10: error: 'struct uart_port' has no member named 'rs485_config' >> >> Culprit: "serial/omap: Use the rs485 functions on serial_core" > > >Thanks Guenter. I'll pull both of these out of 3.18 and 4.1 until we can get a proper >backport since it doesn't seem trivial. > > >Thanks, >Sasha >