From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from muru.com ([72.249.23.125]:47954 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756119AbcCDENZ (ORCPT ); Thu, 3 Mar 2016 23:13:25 -0500 Date: Thu, 3 Mar 2016 20:13:15 -0800 From: Tony Lindgren To: "Woodruff, Richard" Cc: Sasha Levin , "stable@vger.kernel.org" , "stable-commits@vger.kernel.org" , Kees Cook , Laura Abbott , "Menon, Nishanth" , Russell King , "Kristo, Tero" Subject: Re: [added to the 4.1 stable tree] ARM: OMAP2+: Fix wait_dll_lock_timed for rodata Message-ID: <20160304041314.GA21163@atomide.com> References: <1455117136-28870-1-git-send-email-sasha.levin@oracle.com> <1455117136-28870-177-git-send-email-sasha.levin@oracle.com> <20160211162050.GG3500@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: stable-owner@vger.kernel.org List-ID: * Woodruff, Richard [160301 16:24]: > Hi Tony, > > > From: Tony Lindgren [mailto:tony@atomide.com] > > Sent: Thursday, February 11, 2016 10:21 AM > > > Care to check again with the mainline kernel? All the mainline > > code was doing was incrementing these. > > > > > The kick counters were there to work around HW quirks/bugs not for any > > kind of debugging. Code in this area was added reactively to customer > > production failures not for expirmentation. > > I was able to check code over time. > > You are correct the counters were debug only. The DLL wait spin and kick was added to work around a HW errata for OMAP3430. This work around is mandatory. The kick_counter was used as a debug aid to help characterize the time of unlock condition. My initial comment wrongly conflated the kick function with the counter. These are separate. Sorry for any misdirection and delay in being able to check more carefully. OK thanks for checking! Regards, Tony