From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f65.google.com ([74.125.82.65]:34742 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752220AbcCLNB5 (ORCPT ); Sat, 12 Mar 2016 08:01:57 -0500 Received: by mail-wm0-f65.google.com with SMTP id p65so7005012wmp.1 for ; Sat, 12 Mar 2016 05:01:57 -0800 (PST) Date: Sat, 12 Mar 2016 14:03:08 +0100 From: Miklos Szeredi To: stable@vger.kernel.org Cc: koct9i@gmail.com Subject: [PATCH for v4.4] ovl: copy new uid/gid into overlayfs runtime inode Message-ID: <20160312130308.GK8655@tucsk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Sender: stable-owner@vger.kernel.org List-ID: From: Konstantin Khlebnikov Date: Sun, 31 Jan 2016 16:21:29 +0300 commit b81de061fa59f17d2730aabb1b84419ef3913810 upstream. Overlayfs must update uid/gid after chown, otherwise functions like inode_owner_or_capable() will check user against stale uid. Catched by xfstests generic/087, it chowns file and calls utimes. Signed-off-by: Konstantin Khlebnikov Signed-off-by: Miklos Szeredi Cc: --- fs/overlayfs/inode.c | 2 ++ 1 file changed, 2 insertions(+) --- a/fs/overlayfs/inode.c +++ b/fs/overlayfs/inode.c @@ -52,6 +52,8 @@ int ovl_setattr(struct dentry *dentry, s mutex_lock(&upperdentry->d_inode->i_mutex); err = notify_change(upperdentry, attr, NULL); + if (!err) + ovl_copyattr(upperdentry->d_inode, dentry->d_inode); mutex_unlock(&upperdentry->d_inode->i_mutex); } ovl_drop_write(dentry);