From: Greg KH <gregkh@linuxfoundation.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: stable@vger.kernel.org,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
Jussi Kivilinna <jussi.kivilinna@iki.fi>,
patrick.meyer@vasgard.com
Subject: Re: [PATCH] crypto: gcm - Fix rfc4543 decryption crash
Date: Fri, 18 Mar 2016 10:34:23 -0700 [thread overview]
Message-ID: <20160318173423.GB19137@kroah.com> (raw)
In-Reply-To: <20160318144240.GA20816@gondor.apana.org.au>
On Fri, Mar 18, 2016 at 10:42:40PM +0800, Herbert Xu wrote:
> This bug has already bee fixed upstream since 4.2. However, it
> was fixed during the AEAD conversion so no fix was backported to
> the older kernels.
What was the commit id of that fix?
>
> When we do an RFC 4543 decryption, we will end up writing the
> ICV beyond the end of the dst buffer. This should lead to a
> crash but for some reason it was never noticed.
>
> This patch fixes it by only writing back the ICV for encryption.
>
> Fixes: d733ac90f9fe ("crypto: gcm - fix rfc4543 to handle async...")
> Reported-by: Patrick Meyer <patrick.meyer@vasgard.com>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
What stable kernel(s) do you want this in?
thanks,
greg k-h
next prev parent reply other threads:[~2016-03-18 17:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-18 14:42 [PATCH] crypto: gcm - Fix rfc4543 decryption crash Herbert Xu
2016-03-18 17:34 ` Greg KH [this message]
2016-03-19 2:23 ` Herbert Xu
2016-04-26 11:42 ` Ben Hutchings
2016-04-27 4:17 ` Herbert Xu
2016-05-15 19:48 ` Ben Hutchings
2016-04-26 21:05 ` Ben Hutchings
2016-05-01 22:59 ` Patch "crypto: gcm - Fix rfc4543 decryption crash" has been added to the 3.14-stable tree gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160318173423.GB19137@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=jussi.kivilinna@iki.fi \
--cc=linux-crypto@vger.kernel.org \
--cc=patrick.meyer@vasgard.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).