From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:58890 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753323AbcCVU1x (ORCPT ); Tue, 22 Mar 2016 16:27:53 -0400 Date: Tue, 22 Mar 2016 16:27:50 -0400 From: Greg KH To: Alex Deucher Cc: Christian Koenig , Grigori Goronzy , "for 3.8" , Alex Deucher Subject: Re: [PATCH] drm/amdgpu: fix regression on CIK (v2) Message-ID: <20160322202750.GA31394@kroah.com> References: <1458676098-9543-1-git-send-email-alexander.deucher@amd.com> <20160322201120.GA28527@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: stable-owner@vger.kernel.org List-ID: On Tue, Mar 22, 2016 at 04:14:30PM -0400, Alex Deucher wrote: > On Tue, Mar 22, 2016 at 4:11 PM, Greg KH wrote: > > On Tue, Mar 22, 2016 at 03:48:18PM -0400, Alex Deucher wrote: > >> From: Grigori Goronzy > >> > >> This fix was written against drm-next, but when it was > >> backported to 4.5 as a stable fix, the driver internal > >> structure change was missed. Fix that up here to avoid > >> a hang due to waiting for the wrong sequence number. > >> > >> v2: agd: fix up commit message > >> > >> Signed-off-by: Grigori Goronzy > >> Cc: stable@vger.kernel.org > >> Signed-off-by: Alex Deucher > >> --- > >> > >> Hi Greg, > >> > >> The code is correct for 4.6, this fix should be applied to > >> 4.5 and older stable kernels. > > > > What is the patch in 4.6 that made it "correct"? I would much rather > > take that than something else. > > It's correct as is for 4.6. I cherry-picked it out of my drm-next > tree into 4.5 since it was a bug fix, but missed the internal driver > structure change in drm-next that was not in 4.5. I'm sorry, I don't understand at all what you mean here :( What changed between 4.5.0 and 4.6-rc1 that made 4.5 "broken"? What fixed it in 4.6-rc1? totally confused, greg k-h