From: Christoph Hellwig <hch@infradead.org>
To: Ming Lei <ming.lei@canonical.com>
Cc: Jens Axboe <axboe@fb.com>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Naveen Kaje <nkaje@codeaurora.org>,
stable@vger.kernel.org
Subject: Re: [PATCH] block: partition: initialize percpuref before sending out KOBJ_ADD
Date: Wed, 30 Mar 2016 10:43:10 -0700 [thread overview]
Message-ID: <20160330174310.GA9544@infradead.org> (raw)
In-Reply-To: <1459298791-32447-1-git-send-email-ming.lei@canonical.com>
> + if (err) {
> + if (flags & ADDPART_FLAG_WHOLEDISK)
> + goto out_remove_file;
> + goto out_del;
> + }
I'd rather have that if around the actual device_remove_file at the
label, and jump to out_remove_file unconditionally.
Otherwise this looks fine to me.
next prev parent reply other threads:[~2016-03-30 17:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 0:46 [PATCH] block: partition: initialize percpuref before sending out KOBJ_ADD Ming Lei
2016-03-30 17:43 ` Christoph Hellwig [this message]
2016-03-31 2:22 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160330174310.GA9544@infradead.org \
--to=hch@infradead.org \
--cc=axboe@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=nkaje@codeaurora.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox