Re: [PATCH] USB: option: add "D-Link DWM-221 B1" device id

[Johan Hovold <johan@kernel.org>]

On Mon, Mar 28, 2016 at 10:37:35PM +0200, Bj�rn Mork wrote:
> Thomas reports:
> "Windows:
> 
> 00 diagnostics
> 01 modem
> 02 at-port
> 03 nmea
> 04 nic
> 
> Linux:
> 
> T:  Bus=02 Lev=01 Prnt=01 Port=03 Cnt=01 Dev#=  4 Spd=480 MxCh= 0
> D:  Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs=  1
> P:  Vendor=2001 ProdID=7e19 Rev=02.32
> S:  Manufacturer=Mobile Connect
> S:  Product=Mobile Connect
> S:  SerialNumber=0123456789ABCDEF
> C:  #Ifs= 6 Cfg#= 1 Atr=a0 MxPwr=500mA
> I:  If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=option
> I:  If#= 1 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> I:  If#= 2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> I:  If#= 3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> I:  If#= 4 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=qmi_wwan
> I:  If#= 5 Alt= 0 #EPs= 2 Cls=08(stor.) Sub=06 Prot=50 Driver=usb-storage"
> 
> Reported-by: Thomas Sch�fer <tschaefer@t-online.de>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Bj�rn Mork <bjorn@mork.no>
> ---
>  drivers/usb/serial/option.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index 348e19834b83..6ca2cc5790c0 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -1818,6 +1818,8 @@ static const struct usb_device_id option_ids[] = {
>  	{ USB_DEVICE_AND_INTERFACE_INFO(0x2001, 0x7d02, 0xff, 0x00, 0x00) },
>  	{ USB_DEVICE_AND_INTERFACE_INFO(0x2001, 0x7d03, 0xff, 0x02, 0x01) },
>  	{ USB_DEVICE_AND_INTERFACE_INFO(0x2001, 0x7d03, 0xff, 0x00, 0x00) },
> +	{ USB_DEVICE(0x2001, 0x7e19),						/* D-Link DWM-221 B1 */
> +	  .driver_info = (kernel_ulong_t)&net_intf4_blacklist },

Why not use USB_DEVICE_INTERFACE_CLASS here to avoid even trying to
probe the mass-storage interface?

Thanks,
Johan