Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: John Youn <John.Youn@synopsys.com>
Cc: "stable@vger.kernel.org" <stable@vger.kernel.org>,
	Felipe Balbi <balbi@kernel.org>
Subject: Re: usb: gadget: composite: Return bcdUSB 0x0310
Date: Mon, 11 Apr 2016 15:11:09 -0700	[thread overview]
Message-ID: <20160411221109.GB9944@kroah.com> (raw)
In-Reply-To: <570C16E8.9070001@synopsys.com>

On Mon, Apr 11, 2016 at 02:28:08PM -0700, John Youn wrote:
> On 4/8/2016 5:58 PM, Greg Kroah-Hartman wrote:
> > On Fri, Apr 08, 2016 at 04:19:40PM -0700, John Youn wrote:
> >> Hi,
> >>
> >> I'd like to request the following be applied to stable trees 3.2+.
> >>
> >> 1a85329171094951956a37acc8abb7e51c1e742e ("usb: gadget: composite:
> >> Return bcdUSB 0x0310")
> >>
> >> The USB 3.1 specification replaces the USB 3.0 specification and all new
> >> devices that are running at SuperSpeed or higher speeds must report a
> >> bcdUSB of 0x0310.
> > 
> > That doesn't seem very "backwards compatible" of the spec to me, what
> > happens if you return a 3.0 string, when you really are only handling
> > 3.0 things like we do in older kernels?
> > 
> > thanks,
> > 
> > greg k-h
> > 
> 
> Hi Greg,
> 
> I believe there would be no backward-incompatible change as all 3.0
> things are now part of the 3.1 spec, and the new stuff in 3.1 (such as
> SuperSpeedPlus) are exposed through new descriptors. And I don't
> believe anything currently looks at bcdUSB 3.0 vs 3.1 (unlike with USB
> 2.x). But I can't say for sure.
> 
> This is only needed because the CV tool has started requiring this and
> I believe the compliance process will also start requiring it for all
> new devices. We plan to certify new devices with kernels as old as
> 3.18, hence this backport.

For "new" devices, why are you using such an old and obsolete kernel as
3.18?

For an "old" device, a bcdUSB of 3.0 should just be fine, right?

> If you like, I can solicit comments on this from the linux-usb list.

Please do, you need the maintainer of the subsystem to agree to this at
the least :)

thanks,

greg k-h

      reply	other threads:[~2016-04-11 22:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-08 23:19 usb: gadget: composite: Return bcdUSB 0x0310 John Youn
2016-04-09  0:58 ` Greg Kroah-Hartman
2016-04-11 21:28   ` John Youn
2016-04-11 22:11     ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160411221109.GB9944@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=John.Youn@synopsys.com \
    --cc=balbi@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox