From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andi Kleen <ak@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
stable <stable@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>
Subject: Re: FAILED: patch "[PATCH] perf/x86/intel: Fix PEBS data source interpretation on" failed to apply to 4.5-stable tree
Date: Wed, 13 Apr 2016 07:10:51 -0700 [thread overview]
Message-ID: <20160413141051.GA12749@kroah.com> (raw)
In-Reply-To: <20160413075414.GA9286@gmail.com>
On Wed, Apr 13, 2016 at 09:54:14AM +0200, Ingo Molnar wrote:
>
> * Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
> > On Sat, Apr 9, 2016 at 11:13 AM, Andi Kleen <ak@linux.intel.com> wrote:
> > >
> > > Unfortunately perf decided to rename all x86 files, completely
> > > disregarding the needs for backports.
> >
> > So I agree that renaming tends to make backports nastier.
>
> Yeah, and unfortunately there's no other way to do such changes, and the directory
> structure of the x86 drivers of perf grew really badly structured so we had to fix
> it.
>
> In perf we go out on a limb to help backports, I regularly add Cc: stable tags.
>
> In this case we made the renames in a single go to not make backporting a constant
> drip-drip pain, and we made it all as plain as possible, the pattern is very
> visible in the shortlogs as well:
>
> 27f6d22b037b perf/x86: Move perf_event.h to its new home
> 65a27a3510c8 perf/x86: Move perf_event_msr.c .............. => x86/events/msr.c
> 5e865ed44b39 perf/x86: Move perf_event_p6.c ............... => x86/events/intel/p6.c
> f03e97dbd2bb perf/x86: Move perf_event_p4.c ............... => x86/events/intel/p4.c
> edbb591870dc perf/x86: Move perf_event_knc.c .............. => x86/events/intel/knc.c
> ed367e6ca427 perf/x86: Move perf_event_intel_uncore_snbep.c => x86/events/intel/uncore_snbep.c
> 92553e40c629 perf/x86: Move perf_event_intel_uncore_snb.c => x86/events/intel/uncore_snb.c
> 35bf705c25e8 perf/x86: Move perf_event_intel_uncore_nhmex.c => x86/events/intel/uncore_nmhex.c
> 6bcb2db547be perf/x86: Move perf_event_intel_uncore.[ch] .. => x86/events/intel/uncore.[ch]
> 609d809f832d perf/x86: Move perf_event_intel_rapl.c ....... => x86/events/intel/rapl.c
> fd1c601c2578 perf/x86: Move perf_event_intel_pt.[ch] ...... => x86/events/intel/pt.[ch]
> c85cc4497f82 perf/x86: Move perf_event_intel_lbr.c ........ => x86/events/intel/lbr.c
> 7010d129137a perf/x86: Move perf_event_intel_ds.c ......... => x86/events/intel/ds.c
> 6aec1ad73656 perf/x86: Move perf_event_intel_cstate.c ..... => x86/events/intel/cstate.c
> 5c781a3daa30 perf/x86: Move perf_event_intel_cqm.c ........ => x86/events/intel/cqm.c
> e1069839dd68 perf/x86: Move perf_event_intel.c ............ => x86/events/intel/core.c
> af5d3aabc04a perf/x86: Move perf_event_intel_bts.c ........ => x86/events/intel/bts.c
> d0af1c0525d5 perf/x86: Move perf_event_amd_uncore.c .... => x86/events/amd/uncore.c
> 5b26547dd7fa perf/x86: Move perf_event_amd_iommu.[ch] .. => x86/events/amd/iommu.[ch]
> 218cfe4ed888 perf/x86: Move perf_event_amd_ibs.c ....... => x86/events/amd/ibs.c
> 39b0332a2158 perf/x86: Move perf_event_amd.c ........... => x86/events/amd/core.c
> fa9cbf320e99 perf/x86: Move perf_event.c ............... => x86/events/core.c
To be honest, using 'git cherry-pick' solved all of my problems here, so
I'll not complain about renames anymore, or at least not for these files
:)
thanks,
greg k-h
next prev parent reply other threads:[~2016-04-13 14:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-09 17:47 FAILED: patch "[PATCH] perf/x86/intel: Fix PEBS data source interpretation on" failed to apply to 4.5-stable tree gregkh
2016-04-09 18:13 ` Andi Kleen
2016-04-09 19:12 ` Linus Torvalds
2016-04-10 3:50 ` Andi Kleen
2016-04-10 4:34 ` Linus Torvalds
2016-04-13 7:54 ` Ingo Molnar
2016-04-13 14:10 ` Greg Kroah-Hartman [this message]
2016-04-10 18:28 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160413141051.GA12749@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ak@linux.intel.com \
--cc=bp@alien8.de \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).