From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eddie.linux-mips.org ([148.251.95.138]:33236 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751164AbcDOJ7q (ORCPT ); Fri, 15 Apr 2016 05:59:46 -0400 Received: from localhost.localdomain ([127.0.0.1]:56996 "EHLO linux-mips.org" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S27026643AbcDOJ7oXhtyq (ORCPT ); Fri, 15 Apr 2016 11:59:44 +0200 Date: Fri, 15 Apr 2016 11:59:41 +0200 From: Ralf Baechle To: James Hogan Cc: linux-mips@linux-mips.org, Paul Burton , stable@vger.kernel.org Subject: Re: [PATCH 1/4] MIPS: Use copy_s.fmt rather than copy_u.fmt Message-ID: <20160415095941.GI1524@linux-mips.org> References: <1460711246-4394-1-git-send-email-james.hogan@imgtec.com> <1460711246-4394-2-git-send-email-james.hogan@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1460711246-4394-2-git-send-email-james.hogan@imgtec.com> Sender: stable-owner@vger.kernel.org List-ID: On Fri, Apr 15, 2016 at 10:07:23AM +0100, James Hogan wrote: > From: Paul Burton > > In revision 1.12 of the MSA specification, the copy_u.w instruction has > been removed for MIPS32 & the copy_u.d instruction has been removed for > MIPS64. Newer toolchains (eg. Codescape SDK essentials 2015.10) will > complain about this like so: > > arch/mips/kernel/r4k_fpu.S:290: Error: opcode not supported on this > processor: mips32r2 (mips32r2) `copy_u.w $1,$w26[3]' > > Since we always copy to the width of a GPR, simply use copy_s instead of > copy_u to fix this. > > Signed-off-by: Paul Burton > Signed-off-by: James Hogan > Cc: Ralf Baechle > Cc: linux-mips@linux-mips.org > Cc: # 4.1.x- Looking good but seems to apply only to 4.3+ Ralf