From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com ([74.125.82.51]:37206 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757222AbcEDJZO (ORCPT ); Wed, 4 May 2016 05:25:14 -0400 Received: by mail-wm0-f51.google.com with SMTP id a17so82602908wme.0 for ; Wed, 04 May 2016 02:25:13 -0700 (PDT) Date: Wed, 4 May 2016 10:25:10 +0100 From: Matt Fleming To: Ingo Molnar Cc: Thomas Gleixner , "H . Peter Anvin" , Wang YanQing , Ard Biesheuvel , linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, David Herrmann , Peter Jones , stable@vger.kernel.org, Tomi Valkeinen Subject: Re: [PATCH 2/3] x86/sysfb_efi: Fix valid BAR address range check Message-ID: <20160504092510.GD2839@codeblueprint.co.uk> References: <1462303781-8686-1-git-send-email-matt@codeblueprint.co.uk> <1462303781-8686-3-git-send-email-matt@codeblueprint.co.uk> <20160504063524.GB12846@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160504063524.GB12846@gmail.com> Sender: stable-owner@vger.kernel.org List-ID: On Wed, 04 May, at 08:35:24AM, Ingo Molnar wrote: > > * Matt Fleming wrote: > > > From: Wang YanQing > > > > We can't just break out when meet start is equal to zero, > > Hm, wot? The existing code treats address 0x0 as invalid for a PCI BAR range start address, but 0x0 is actually possible and legitimate, so we shouldn't be breaking out of the loop.