From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from imap.thunk.org ([74.207.234.97]:50136 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755270AbcEEPLH (ORCPT ); Thu, 5 May 2016 11:11:07 -0400 Date: Thu, 5 May 2016 11:11:03 -0400 From: Theodore Ts'o To: Jan Kara Cc: linux-ext4@vger.kernel.org, Vegard Nossum , stable@vger.kernel.org Subject: Re: [PATCH] ext4: Fix oops on corrupted filesystem Message-ID: <20160505151103.GA10764@thunk.org> References: <1462200664-4825-1-git-send-email-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462200664-4825-1-git-send-email-jack@suse.cz> Sender: stable-owner@vger.kernel.org List-ID: On Mon, May 02, 2016 at 04:51:04PM +0200, Jan Kara wrote: > When filesystem is corrupted in the right way, it can happen > ext4_mark_iloc_dirty() in ext4_orphan_add() returns error and we > subsequently remove inode from the in-memory orphan list. However this > deletion is done with list_del(&EXT4_I(inode)->i_orphan) and thus we > leave i_orphan list_head with a stale content. Later we can look at this > content causing list corruption, oops, or other issues. The reported > trace looked like:... Applied, thanks. - Ted