From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mail.linuxfoundation.org ([140.211.169.12]:50419 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756308AbcEFR0M (ORCPT
	<rfc822;stable@vger.kernel.org>); Fri, 6 May 2016 13:26:12 -0400
Date: Fri, 6 May 2016 12:06:38 -0400
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: John Stultz <john.stultz@linaro.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Tyler Baker <tyler.baker@linaro.org>,
	Thierry Reding <treding@nvidia.com>,
	stable <stable@vger.kernel.org>
Subject: Re: [RFC][PATCH 4.4-stable] regulator: core: Ensure we lock all
 regulators
Message-ID: <20160506160638.GA3479@kroah.com>
References: <1461890617-29209-1-git-send-email-john.stultz@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1461890617-29209-1-git-send-email-john.stultz@linaro.org>
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Thu, Apr 28, 2016 at 05:43:37PM -0700, John Stultz wrote:
> It seems upstream commit 49a6bb7a1c09 ("regulator: core: Ensure
> we lock all regulators"), was missed when considering tagging
> for -stable.
> 
> Without this varient of that patch (the original doesn't apply,
> due to a later fix to the same which was backported), I see
> double-unlock lockdep splats in the v4.4.8 based HiKey kernel.
> 
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Tyler Baker <tyler.baker@linaro.org>
> Cc: Thierry Reding <treding@nvidia.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> CC: stable <stable@vger.kernel.org> # 4.4 only (I think)
> Fixes: 3c2c5fb9b99ca ("regulator: core: avoid unused variable warning")
> Originally-Reported-by: Tyler Baker <tyler.baker@linaro.org>
> Originally-by: Mark Brown <broonie@kernel.org>
> Signed-off-by: John Stultz <john.stultz@linaro.org>
> ---
>  drivers/regulator/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> index 7b94b8e..732ac71 100644
> --- a/drivers/regulator/core.c
> +++ b/drivers/regulator/core.c
> @@ -148,7 +148,7 @@ static void regulator_lock_supply(struct regulator_dev *rdev)
>  {
>  	int i;
>  
> -	for (i = 0; rdev->supply; rdev = rdev_get_supply(rdev), i++)
> +	for (i = 0; rdev; rdev = rdev_get_supply(rdev), i++)
>  		mutex_lock_nested(&rdev->mutex, i);
>  }
>  

This should now all be fixed in 4.4.9, and this patch isn't needed,
right?

thanks,

greg k-h