From: Keith Busch <keith.busch@intel.com>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Wenbo Wang <mail_weber_wang@163.com>,
axboe@fb.com, stable@vger.kernel.org, wenwei.tao@memblaze.com,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
Wenbo Wang <wenbo.wang@memblaze.com>
Subject: Re: [PATH v2] NVMe: init nvme queue before enabling irq
Date: Wed, 11 May 2016 15:16:33 -0400 [thread overview]
Message-ID: <20160511191632.GC31047@localhost.localdomain> (raw)
In-Reply-To: <e41c65a6b6637ef16f7f11ac147a9466@suse.de>
On Wed, May 11, 2016 at 11:25:16AM +0200, Johannes Thumshirn wrote:
> What ever happened to this patch?
> I can easily reproduce the bug using
> while [ true ]; do rmmod nvme nvme_core; modprobe nvme; done
This patch was supposed to fix using a doorbell between resets when the
driver had BAR0 unmapped. We don't ever unmap the bar anymore, so this
patch shouldn't be necessary: the doorbell is already set during queue
allocation before requset_irq.
The test doesn't seem like this patch would help either. It sounds
more like you're hitting somethine else if you don't have this fix:
https://git.kernel.org/cgit/linux/kernel/git/axboe/linux-block.git/commit/?h=for-linus&id=9bf2b972afeaffd173fe2ce211ebc555ea7e8a87
If you do have that fix already, I'd like to see the panic stack trace
(assuming that's what happened).
next prev parent reply other threads:[~2016-05-11 19:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 10:48 [PATH v2] NVMe: init nvme queue before enabling irq Wenbo Wang
2016-01-20 12:34 ` Sagi Grimberg
2016-01-20 14:57 ` Keith Busch
2016-01-20 15:13 ` Johannes Thumshirn
2016-01-20 17:12 ` Greg KH
2016-01-20 17:17 ` Jens Axboe
2016-05-10 9:13 ` Johannes Thumshirn
2016-04-25 9:14 ` Johannes Thumshirn
2016-05-11 9:25 ` Johannes Thumshirn
2016-05-11 19:16 ` Keith Busch [this message]
2016-05-12 7:12 ` Johannes Thumshirn
2016-05-12 10:55 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160511191632.GC31047@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=axboe@fb.com \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mail_weber_wang@163.com \
--cc=stable@vger.kernel.org \
--cc=wenbo.wang@memblaze.com \
--cc=wenwei.tao@memblaze.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).