From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 11 May 2016 15:16:33 -0400 From: Keith Busch To: Johannes Thumshirn Cc: Wenbo Wang , axboe@fb.com, stable@vger.kernel.org, wenwei.tao@memblaze.com, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Wenbo Wang Subject: Re: [PATH v2] NVMe: init nvme queue before enabling irq Message-ID: <20160511191632.GC31047@localhost.localdomain> References: <1453286915-18814-1-git-send-email-mail_weber_wang@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: On Wed, May 11, 2016 at 11:25:16AM +0200, Johannes Thumshirn wrote: > What ever happened to this patch? > I can easily reproduce the bug using > while [ true ]; do rmmod nvme nvme_core; modprobe nvme; done This patch was supposed to fix using a doorbell between resets when the driver had BAR0 unmapped. We don't ever unmap the bar anymore, so this patch shouldn't be necessary: the doorbell is already set during queue allocation before requset_irq. The test doesn't seem like this patch would help either. It sounds more like you're hitting somethine else if you don't have this fix: https://git.kernel.org/cgit/linux/kernel/git/axboe/linux-block.git/commit/?h=for-linus&id=9bf2b972afeaffd173fe2ce211ebc555ea7e8a87 If you do have that fix already, I'd like to see the panic stack trace (assuming that's what happened).