Re: [PATCH] fbcon: warn on invalid cursor blink intervals

Scot Doyle
2016-05-24T01:20:04Z

On Fri, 20 May 2016, Scot Doyle wrote:
> On Fri, 20 May 2016, Jeremy Kerr wrote:
> > Hi Ming,
> >
> > >Then looks there are two fix patches acked & tested:
> > >
> > > - the patch in this thread
> > > - another one "[PATCH] tty: vt: Fix soft lockup in fbcon cursor
> > >blink timer."
> > > https://lkml.org/lkml/2016/5/17/455
> > >
> > >So which one will be pushed to linus?
> >
> > Not that it's my call, but we may want both; the first as a safety
> > measure to prevent an invalid cur_blink_jiffies ever being set, and the
> > second one to actually fix the initialisation of vc_cur_blink_ms (and
> > address the warning introduced by the first).
>
> Tomi / Greg,
>
> I'd suggest
> - applying "tty: vt: Fix soft lockup in fbcon cursor blink timer." to 4.7 and stable[4.2]
> - applying "fbcon: warn on invalid cursor blink intervals" to 4.7
> - ignoring "fbcon: use default if cursor blink interval is not valid"
>
> Note: the patches don't depend on each other

"tty: vt: Fix soft lockup..." should be applied first in order to avoid
unnecessary reports due to the log warning in "fbcon: warn on invalid..."

>
> > I guess we could just go with the latter for stable...
> >
> > Cheers,
> >
> > Jeremy