From: Mark Brown <broonie@kernel.org>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
alsa-devel@alsa-project.org, stable@vger.kernel.org
Subject: Re: [PATCH] ASoC: ak4642: Enable cache usage to fix crashes on resume
Date: Thu, 19 May 2016 11:10:01 +0100 [thread overview]
Message-ID: <20160519101001.GB8206@sirena.org.uk> (raw)
In-Reply-To: <52f206d4-ea9d-0cfc-613a-c625298cb9b2@ti.com>
[-- Attachment #1: Type: text/plain, Size: 606 bytes --]
On Thu, May 19, 2016 at 09:33:15AM +0300, Peter Ujfalusi wrote:
> Should the ak4642 implement the suspend callback and:
> static int ak4642_suspend(struct snd_soc_codec *codec)
> {
> struct regmap *regmap = dev_get_regmap(codec->dev, NULL);
>
> regcache_cache_only(regmap, true);
> I know it is highly unlikely that anything is going to be written to the chip
> while the board is suspended. Probably the suspend and changing the cache only
> is not needed, but in this way things look a bit more complete?
Yes, that's more idiomatic - it also allows better sharing with runtime
PM.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2016-05-19 10:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 17:49 [PATCH] ASoC: ak4642: Enable cache usage to fix crashes on resume Mark Brown
2016-05-18 18:05 ` Geert Uytterhoeven
2016-05-18 18:13 ` Applied "ASoC: ak4642: Enable cache usage to fix crashes on resume" to the asoc tree Mark Brown
2016-05-19 6:33 ` [PATCH] ASoC: ak4642: Enable cache usage to fix crashes on resume Peter Ujfalusi
2016-05-19 10:10 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160519101001.GB8206@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=geert@linux-m68k.org \
--cc=peter.ujfalusi@ti.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox