public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: "Chris Wilson" <chris@chris-wilson.co.uk>,
	"Radek Dostál" <rd@radekdostal.com>,
	dri-devel@lists.freedesktop.org,
	"Jesse Barnes" <jbarnes@virtuousgeek.org>,
	"Daniel Vetter" <daniel.vetter@ffwll.ch>,
	"Julia Lemire" <jlemire@matrox.com>,
	"Dave Airlie" <airlied@redhat.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH v4] drm: Only create a cmdline mode if no probed modes match
Date: Thu, 2 Jun 2016 14:30:40 +0300	[thread overview]
Message-ID: <20160602113040.GK4329@intel.com> (raw)
In-Reply-To: <20160602105217.GL10319@nuc-i3427.alporthouse.com>

On Thu, Jun 02, 2016 at 11:52:17AM +0100, Chris Wilson wrote:
> On Thu, Jun 02, 2016 at 11:38:26AM +0200, Radek Dost�l wrote:
> > On 06/01/2016 11:50 AM, Chris Wilson wrote:
> > >Fixes regression from
> > >
> > >commit eaf99c749d43ae74ac7ffece5512f3c73f01dfd2
> > >Author: Chris Wilson<chris@chris-wilson.co.uk>
> > >Date:   Wed Aug 6 10:08:32 2014 +0200
> > >
> > >     drm: Perform cmdline mode parsing during connector initialisation
> > >
> > >that breaks HDMI output on BeagleBone Black with LG TV (model 19LS4R-ZA).
> > 
> > please remove this from the commit message. The original bug is no
> > longer reproducible with 4.7-rc1
> 
> If there's no motivation for the patch anymore, it can just wither away
> in one of my old trees.
> 
> Does anyone care about pruning the autogenerated video= mode if a probed
> one matches? Presumably, it is still visible to userspace and switching
> to it will cause the same issue as before? Or was it always a driver
> bug (failing to set the mode)?

IMO the patch makes total sense even if it's not needed for this
particular bug. Feel free to add

Reviewed-by: Ville Syrj�l� <ville.syrjala@linux.intel.com>

-- 
Ville Syrj�l�
Intel OTC

  reply	other threads:[~2016-06-02 11:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1429532795-3922-1-git-send-email-chris@chris-wilson.co.uk>
2016-06-01  9:34 ` [PATCH v3] drm: Only create a cmdline mode if no probed modes match Chris Wilson
2016-06-01  9:43   ` Ville Syrjälä
2016-06-01  9:46     ` Chris Wilson
2016-06-01  9:47     ` Chris Wilson
2016-06-01  9:56       ` Ville Syrjälä
2016-06-01  9:50     ` [PATCH v4] " Chris Wilson
2016-06-01 13:19       ` Alex Deucher
2016-06-02  9:38       ` Radek Dostál
2016-06-02 10:52         ` Chris Wilson
2016-06-02 11:30           ` Ville Syrjälä [this message]
2016-06-02 11:35             ` Radek Dostál
2016-06-02 13:12             ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160602113040.GK4329@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=airlied@redhat.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jbarnes@virtuousgeek.org \
    --cc=jlemire@matrox.com \
    --cc=rd@radekdostal.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox