From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:52389 "EHLO mx0b-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750747AbcFDCdL (ORCPT ); Fri, 3 Jun 2016 22:33:11 -0400 Received: from pps.filterd (m0048827.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u542T0Lu044359 for ; Fri, 3 Jun 2016 22:33:10 -0400 Message-Id: <201606040233.u542T0Lu044359@mx0a-001b2d01.pphosted.com> Received: from e24smtp04.br.ibm.com (e24smtp04.br.ibm.com [32.104.18.25]) by mx0a-001b2d01.pphosted.com with ESMTP id 23bcphrv3h-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Fri, 03 Jun 2016 22:33:10 -0400 Received: from localhost by e24smtp04.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 3 Jun 2016 23:33:08 -0300 Subject: Re: [added to the 4.1 stable tree] powerpc/iommu: Remove the dependency on EEH struct in DDW mechanism To: Sasha Levin References: <1464989831-16666-1-git-send-email-sasha.levin@oracle.com> <1464989831-16666-88-git-send-email-sasha.levin@oracle.com> Cc: stable@vger.kernel.org, stable-commits@vger.kernel.org, Michael Ellerman , Gavin Shan From: "Guilherme G. Piccoli" Date: Fri, 3 Jun 2016 23:33:03 -0300 MIME-Version: 1.0 In-Reply-To: <1464989831-16666-88-git-send-email-sasha.levin@oracle.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On 06/03/2016 06:36 PM, Sasha Levin wrote: > From: "Guilherme G. Piccoli" > > This patch has been added to the 4.1 stable tree. If you have any > objections, please let us know. > > =============== > > [ Upstream commit 8445a87f7092bc8336ea1305be9306f26b846d93 ] > > Commit 39baadbf36ce ("powerpc/eeh: Remove eeh information from pci_dn") > changed the pci_dn struct by removing its EEH-related members. > As part of this clean-up, DDW mechanism was modified to read the device > configuration address from eeh_dev struct. > > As a consequence, now if we disable EEH mechanism on kernel command-line > for example, the DDW mechanism will fail, generating a kernel oops by > dereferencing a NULL pointer (which turns to be the eeh_dev pointer). > > This patch just changes the configuration address calculation on DDW > functions to a manual calculation based on pci_dn members instead of > using eeh_dev-based address. > > No functional changes were made. This was tested on pSeries, both > in PHyp and qemu guest. > > Fixes: 39baadbf36ce ("powerpc/eeh: Remove eeh information from pci_dn") > Cc: stable@vger.kernel.org # v3.4+ > Reviewed-by: Gavin Shan > Signed-off-by: Guilherme G. Piccoli > Signed-off-by: Michael Ellerman > Signed-off-by: Sasha Levin Hi Sasha, thanks for letting me know. Unfortunately, this patch has an issue; the proposed fix is simple and was already sent to linuxppc-dev list by Gavin Shan. Link to the proposed fix (already tested): https://patchwork.ozlabs.org/patch/626492 Thanks, and sorry for the inconvenience. Cheers, Guilherme