From: Christoph Hellwig <hch@infradead.org>
To: Max Gurtovoy <maxg@mellanox.com>
Cc: robert@leblancnet.us, matanb@mellanox.com, leon@leon.nu,
sagi@grimberg.me, linux-rdma@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v3 2/2] IB/core: Align casting method of ib_device_cap_flags enumerations to ULL
Date: Mon, 6 Jun 2016 10:04:13 -0700 [thread overview]
Message-ID: <20160606170413.GB28622@infradead.org> (raw)
In-Reply-To: <1465230880-25953-3-git-send-email-maxg@mellanox.com>
On Mon, Jun 06, 2016 at 07:34:40PM +0300, Max Gurtovoy wrote:
> Replace u64 casting to ULL.
>
> Signed-off-by: Max Gurtovoy <maxg@mellanox.com>
> ---
> include/rdma/ib_verbs.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h
> index c97357b..7e440d4 100644
> --- a/include/rdma/ib_verbs.h
> +++ b/include/rdma/ib_verbs.h
> @@ -219,8 +219,8 @@ enum ib_device_cap_flags {
> IB_DEVICE_SIGNATURE_HANDOVER = (1 << 30),
> IB_DEVICE_ON_DEMAND_PAGING = (1ULL << 31),
> IB_DEVICE_SG_GAPS_REG = (1ULL << 32),
> - IB_DEVICE_VIRTUAL_FUNCTION = ((u64)1 << 33),
> - IB_DEVICE_RAW_SCATTER_FCS = ((u64)1 << 34),
> + IB_DEVICE_VIRTUAL_FUNCTION = (1ULL << 33),
> + IB_DEVICE_RAW_SCATTER_FCS = (1ULL << 34),
Looks good, but can you also convert the whole enum to this
style?
next prev parent reply other threads:[~2016-06-06 17:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 16:34 [PATCH v3 0/2] fix ib_device_cap_flags bit curruption Max Gurtovoy
2016-06-06 16:34 ` [PATCH v3 1/2] IB/core: Fix bit curruption in ib_device_cap_flags structure Max Gurtovoy
2016-06-06 17:03 ` Christoph Hellwig
2016-06-06 16:34 ` [PATCH v3 2/2] IB/core: Align casting method of ib_device_cap_flags enumerations to ULL Max Gurtovoy
2016-06-06 17:04 ` Christoph Hellwig [this message]
2016-06-06 17:15 ` Greg KH
2016-06-06 17:22 ` Christoph Hellwig
2016-06-06 18:31 ` Max Gurtovoy
[not found] ` <CALq1K=JWPk6nPjTV0z1HwfmtnO77Nkyaqx-JTB=8JwH0UtorDA@mail.gmail.com>
2016-06-06 17:22 ` hch
2016-06-06 17:40 ` Greg KH
2016-06-06 17:45 ` Bart Van Assche
2016-06-07 12:00 ` [PATCH v3 0/2] fix ib_device_cap_flags bit curruption Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160606170413.GB28622@infradead.org \
--to=hch@infradead.org \
--cc=leon@leon.nu \
--cc=linux-rdma@vger.kernel.org \
--cc=matanb@mellanox.com \
--cc=maxg@mellanox.com \
--cc=robert@leblancnet.us \
--cc=sagi@grimberg.me \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).