From: Daniel Vetter <daniel@ffwll.ch>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: "Lyude Paul" <cpaul@redhat.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Daniel Vetter" <daniel.vetter@intel.com>,
intel-gfx@lists.freedesktop.org,
"open list:INTEL DRM DRIVERS excluding Poulsbo, Moorestow...,
linux-kernel@vger.kernel.org open list"
<dri-devel@lists.freedesktop.org>,
stable@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH v4] drm/i915/ilk: Don't disable SSC source if it's in use
Date: Tue, 7 Jun 2016 21:37:39 +0200 [thread overview]
Message-ID: <20160607193739.GD3363@phenom.ffwll.local> (raw)
In-Reply-To: <87ziqx5vn8.fsf@intel.com>
On Tue, Jun 07, 2016 at 10:02:35AM +0300, Jani Nikula wrote:
> On Mon, 06 Jun 2016, Lyude Paul <cpaul@redhat.com> wrote:
> > On Mon, 2016-06-06 at 14:30 +0300, Ville Syrj�l� wrote:
> >> On Thu, May 26, 2016 at 09:54:56AM +0200, Daniel Vetter wrote:
> >> >
> >> > Queued for -next, thanks for the patch.
> >> Looks like this one broke one of the ILKs in CI.
> >>
> >> [���13.100979] [drm:ironlake_init_pch_refclk] has_panel 1 has_lvds 1 has_ck505
> >> 0 using_ssc_source 1
> >> [���13.101413] ------------[ cut here ]------------
> >> [���13.101429] kernel BUG at drivers/gpu/drm/i915/intel_display.c:8528!
> >>
> >> which is the 'BUG_ON(val != final)' at the end of ironlake_init_pch_refclk().
> >>
> > Managed to find a machine at the office here that I could reproduce this on and
> > figured out the problem with the patch. Unfortunately, the Optiplex 990 that I
> > was seeing this issue on already left the office and the person in charge of it
> > just went on PTO until the end of the week. For the time being don't merge this
> > patch until I can get access to that machine again and make sure the fixed
> > version of this patch still works on the 990. I'll send the new version once I'm
> > able to test it.
>
> Daniel already merged it, should we revert?
Oops, can do. Or if I have a fixup right away we can merge that, too.
Waiting otoh isn't cool. Lyude?
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
prev parent reply other threads:[~2016-06-07 19:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-23 18:56 [PATCH] drm/i915/ilk: Disable SSC for DPLLs if we're not using it Lyude
2016-05-23 19:16 ` [Intel-gfx] " Ville Syrjälä
2016-05-23 19:56 ` [PATCH v2] drm/i915/ilk: Don't disable SSC source if it's in use Lyude
2016-05-24 13:14 ` Ville Syrjälä
2016-05-24 14:08 ` Lyude Paul
2016-05-24 14:27 ` [PATCH v3] " Lyude
2016-05-24 18:59 ` Ville Syrjälä
2016-05-25 18:11 ` [PATCH v4] " Lyude
2016-05-26 7:54 ` [Intel-gfx] " Daniel Vetter
2016-06-06 11:30 ` Ville Syrjälä
2016-06-06 19:29 ` Lyude Paul
2016-06-07 7:02 ` Jani Nikula
2016-06-07 19:37 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160607193739.GD3363@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=cpaul@redhat.com \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=stable@vger.kernel.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).