Re: [PATCH v2 1/2] fs: Improve and simplify copy_mount_options

Willy Tarreau
2016-06-16T07:02:51Z

On Thu, Jun 16, 2016 at 08:57:38AM +0200, Willy Tarreau wrote:
(...)
> + /* avoid reading a whole page if the FS only needs a string. */
> + if (!(type->fs_flags & FS_BINARY_MOUNTDATA)) {
> + strlcpy(copy, data, PAGE_SIZE);

BTW, I forgot that we're first supposed to come from user, make that
strndup_user() instead.

Willy