From: Borislav Petkov <bp@alien8.de>
To: Thomas Gleixner <tglx@linutronix.de>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
lkml <linux-kernel@vger.kernel.org>,
John Stultz <john.stultz@linaro.org>,
Logan Gunthorpe <logang@deltatee.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Kees Cook <keescook@chromium.org>,
stable@vger.kernel.org, Andy Lutomirski <luto@kernel.org>,
Brian Gerst <brgerst@gmail.com>,
Denys Vlasenko <dvlasenk@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux PM list <linux-pm@vger.kernel.org>,
Stephen Smalley <sds@tycho.nsa.gov>
Subject: Re: ktime_get_ts64() splat during resume
Date: Fri, 17 Jun 2016 16:33:46 +0200 [thread overview]
Message-ID: <20160617143346.GA3912@pd.tnic> (raw)
In-Reply-To: <20160617132943.GA3336@nazgul.tnic>
Ok,
bisect is done, full log below.
Rafael, that fix
70595b479ce1 ("x86/power/64: Fix crash whan the hibernation code passes control to the image kernel")
breaks s2disk here. It explodes during resume and a statically allocated
struct's member is NULL. See
https://lkml.kernel.org/r/20160617105435.GB15997@pd.tnic
for the splat and some debugging attempts.
Reverting 70595b479ce1 fixes the issue here.
@stable folk: You might want to hold off on picking up that one yet...
Now, I have serial connected to that box so if you want me to dump stuff
and try patches, let me know.
Btw, while I have your ear, can you pick up my einj fixes please?
:-)
-> https://lkml.kernel.org/r/1463992084-10012-1-git-send-email-bp@alien8.de
Thanks!
git bisect start
# bad: [f0e52976a6fad5aa2c8868d5fa91deee91299ebb] Merge remote-tracking branch 'tip/master' into tip-timers-splat
git bisect bad f0e52976a6fad5aa2c8868d5fa91deee91299ebb
# good: [bb967271c0317de8eed56b20aae978d31507b033] Merge tag 'pwm/for-4.7-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/thierry.reding/linux-pwm
git bisect good bb967271c0317de8eed56b20aae978d31507b033
# good: [bb41dcd3fd81971ce17f7c0e5020d343d905358f] Merge branch 'sched/core'
git bisect good bb41dcd3fd81971ce17f7c0e5020d343d905358f
# bad: [457642d3e6e1f7412c8174dbaeb06232618b2698] Merge branch 'x86/mm'
git bisect bad 457642d3e6e1f7412c8174dbaeb06232618b2698
# bad: [d818e3414b9def094a93ce57caad9cb75ecb2a17] Merge branch 'x86/boot'
git bisect bad d818e3414b9def094a93ce57caad9cb75ecb2a17
# good: [02e8fda2cc00419a11cf38199afea4c0d7172be8] x86/signals: Add build-time checks to the siginfo compat code
git bisect good 02e8fda2cc00419a11cf38199afea4c0d7172be8
# good: [c702ff2fc395d8d9949eef8f72fd8726943c5aa1] Merge branch 'timers/core'
git bisect good c702ff2fc395d8d9949eef8f72fd8726943c5aa1
# good: [0ef1f6adccfea59c600edca7632ff0834ddfee5b] Merge branch 'x86/asm'
git bisect good 0ef1f6adccfea59c600edca7632ff0834ddfee5b
# bad: [70595b479ce173425dd5cb347dc6c8b1060dfb2c] x86/power/64: Fix crash whan the hibernation code passes control to the image kernel
git bisect bad 70595b479ce173425dd5cb347dc6c8b1060dfb2c
# good: [8d950d2fb23b696d393020486ab6a350bcb2c582] MAINTAINERS: Update the Calgary IOMMU entry
git bisect good 8d950d2fb23b696d393020486ab6a350bcb2c582
# first bad commit: [70595b479ce173425dd5cb347dc6c8b1060dfb2c] x86/power/64: Fix crash whan the hibernation code passes control to the image kernel
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
next parent reply other threads:[~2016-06-17 14:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160617105435.GB15997@pd.tnic>
[not found] ` <alpine.DEB.2.11.1606171351390.5839@nanos>
[not found] ` <20160617132943.GA3336@nazgul.tnic>
2016-06-17 14:33 ` Borislav Petkov [this message]
2016-06-17 15:28 ` ktime_get_ts64() splat during resume Rafael J. Wysocki
2016-06-17 16:12 ` Borislav Petkov
2016-06-17 21:03 ` Rafael J. Wysocki
2016-06-18 1:11 ` Rafael J. Wysocki
2016-06-20 14:38 ` Rafael J. Wysocki
2016-06-20 18:29 ` Linus Torvalds
2016-06-20 21:15 ` Rafael J. Wysocki
2016-06-21 0:05 ` Rafael J. Wysocki
2016-06-21 1:22 ` Rafael J. Wysocki
2016-06-21 4:35 ` Logan Gunthorpe
2016-06-21 11:36 ` Rafael J. Wysocki
2016-06-21 18:04 ` Kees Cook
2016-06-21 23:29 ` Rafael J. Wysocki
2016-06-20 8:17 ` chenyu
2016-06-20 12:21 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160617143346.GA3912@pd.tnic \
--to=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=dvlasenk@redhat.com \
--cc=hpa@zytor.com \
--cc=john.stultz@linaro.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rjw@rjwysocki.net \
--cc=sds@tycho.nsa.gov \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).