From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from Chamillionaire.breakpoint.cc ([80.244.247.6]:35748 "EHLO
	Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751571AbcFWIy4 (ORCPT
	<rfc822;stable@vger.kernel.org>); Thu, 23 Jun 2016 04:54:56 -0400
Date: Thu, 23 Jun 2016 10:54:50 +0200
From: Florian Westphal <fw@strlen.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	Florian Westphal <fw@strlen.de>,
	Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [PATCH 3.14 21/29] netfilter: x_tables: validate targets of jumps
Message-ID: <20160623085450.GA4662@breakpoint.cc>
References: <20160622223530.496939726@linuxfoundation.org>
 <20160622223531.668543902@linuxfoundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160622223531.668543902@linuxfoundation.org>
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> 3.14-stable review patch.  If anyone has any objections, please let me know.

I have -- this doesn't work in 3.14 as t->entries (the ruleset blob)
is still kept percpu.

> +static bool find_jump_target(const struct xt_table_info *t,
> +			     const struct arpt_entry *target)
> +{
> +	struct arpt_entry *iter;
> +
> +	xt_entry_foreach(iter, t->entries, t->size) {


.. so this causes in kernel soft lockup when I try to insert a rule.

I will go over the 3.14 stable queue and see if I can amend this to work
with 3.14.