From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: peterhuewe@gmx.de, jgunthorpe@obsidianresearch.com,
tpmdd@selhorst.net, david.vrabel@citrix.com,
"tpmdd-devel@lists.sourceforge.net"
<tpmdd-devel@lists.sourceforge.net>,
xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com,
Juergen Gross <JGross@suse.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] xen-tpmfront: correct return value check on xenbus_scanf()
Date: Thu, 7 Jul 2016 13:38:59 +0300 [thread overview]
Message-ID: <20160707103859.GA13815@intel.com> (raw)
In-Reply-To: <20160707103554.GA13244@intel.com>
On Thu, Jul 07, 2016 at 01:35:54PM +0300, Jarkko Sakkinen wrote:
> On Thu, Jul 07, 2016 at 02:04:00AM -0600, Jan Beulich wrote:
> > Only a positive return value indicates success.
> >
> > Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Applied. Should this be CC'd to stable or not?
/Jarkko
> /Jarkko
>
> > ---
> > drivers/char/tpm/xen-tpmfront.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > --- 4.7-rc6-xenbus_scanf.orig/drivers/char/tpm/xen-tpmfront.c
> > +++ 4.7-rc6-xenbus_scanf/drivers/char/tpm/xen-tpmfront.c
> > @@ -344,7 +344,7 @@ static void backend_changed(struct xenbu
> > break;
> >
> > if (xenbus_scanf(XBT_NIL, dev->otherend,
> > - "feature-protocol-v2", "%d", &val) < 0)
> > + "feature-protocol-v2", "%d", &val) <= 0)
> > val = 0;
> > if (!val) {
> > xenbus_dev_fatal(dev, -EINVAL,
> >
> >
> >
next parent reply other threads:[~2016-07-07 10:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <577E291002000078000FBF18@prv-mh.provo.novell.com>
[not found] ` <20160707103554.GA13244@intel.com>
2016-07-07 10:38 ` Jarkko Sakkinen [this message]
2016-07-07 12:00 ` [PATCH] xen-tpmfront: correct return value check on xenbus_scanf() Jan Beulich
2016-07-07 12:21 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160707103859.GA13815@intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=JBeulich@suse.com \
--cc=JGross@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=peterhuewe@gmx.de \
--cc=stable@vger.kernel.org \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox