From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mail.skyhub.de ([78.46.96.112]:51107 "EHLO mail.skyhub.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754074AbcGHLJD (ORCPT <rfc822;stable@vger.kernel.org>);
	Fri, 8 Jul 2016 07:09:03 -0400
Date: Fri, 8 Jul 2016 13:09:00 +0200
From: Borislav Petkov <bp@alien8.de>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, linux-kernel@vger.kernel.org,
	kvm@vger.kernel.org, stable@vger.kernel.org,
	Yazen Ghannam <yazen.ghannam@amd.com>,
	Brijesh Singh <brijesh.singh@amd.com>
Subject: Re: [PATCH] KVM: SVM: fix trashing of MSR_TSC_AUX
Message-ID: <20160708110900.GF3808@pd.tnic>
References: <20160707104128.GC13648@pd.tnic>
 <128bb0be-e597-32c0-f113-9fe02c257790@redhat.com>
 <20160707114717.GD13648@pd.tnic>
 <8c66c2b5-58fe-7384-31a3-f6f784461ca6@redhat.com>
 <20160707124712.GE13648@pd.tnic>
 <21b7a239-5fac-b6bf-a48f-71fa456a9c97@redhat.com>
 <20160707160146.GH13648@pd.tnic>
 <20160707162755.GD4131@thinpad.lan.raisama.net>
 <20160707170442.GK13648@pd.tnic>
 <20160707174349.GH4131@thinpad.lan.raisama.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20160707174349.GH4131@thinpad.lan.raisama.net>
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Thu, Jul 07, 2016 at 02:43:49PM -0300, Eduardo Habkost wrote:
> I see. If you have an useful use case for it, we may consider
> that. But first I would like to see an actual case where a
> feature was not added to GET_SUPPORTED_CPUID yet, but would not
> crash and burn if forcibly enabled by QEMU.

Ok.

> I mean live migration to a different host (that normally has the
> same CPU vendor). When you live-migrate or use savevm, you need
> to send the machine state to the other host. This is implemented
> using VMStateDescription structs describing the data to be
> migrated. See vmstate_x86_cpu in target-i386/machine.c, for
> example.
> 
> You need additional migration sections if the feature introduces
> additional state (e.g. CPU registers) that need to be migrated
> too, to keep the feature working. If there's new state but no
> migration support is implemented yet, you need to add the feature
> to unmigratable_flags.
> 
> For an example where no additional state is introduced by new
> features, see:

Thanks for the examples and the explanation - I see the deal now.

Ok, I'll go through the features and see what kind of state the kernel
programs in there and add them to a VMStateDescription thing. Hohumm,
makes sense to me.

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.