From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f65.google.com ([74.125.82.65]:36590 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752586AbcGSGkf (ORCPT ); Tue, 19 Jul 2016 02:40:35 -0400 Received: by mail-wm0-f65.google.com with SMTP id x83so1618321wma.3 for ; Mon, 18 Jul 2016 23:40:34 -0700 (PDT) Date: Tue, 19 Jul 2016 08:40:31 +0200 From: Daniel Vetter To: Rodrigo Vivi Cc: intel-gfx@lists.freedesktop.org, Jani Nikula , Stable Subject: Re: [Intel-gfx] [PATCH] drm/i915/guc: Revert "drm/i915/guc: enable GuC loading & submission by default" Message-ID: <20160719064031.GD17101@phenom.ffwll.local> References: <1468884477-30086-1-git-send-email-rodrigo.vivi@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1468884477-30086-1-git-send-email-rodrigo.vivi@intel.com> Sender: stable-owner@vger.kernel.org List-ID: On Mon, Jul 18, 2016 at 04:27:57PM -0700, Rodrigo Vivi wrote: > This reverts commit 041824ee25cfc535ba2d9a22c217df735ea2471e. > > We have latency issues that might impact the performance: #96606. > and hangs and loading issues on resume after S4: #96526. > > This is also blocking a platform milestone so let's disable > this for now while we make sure we don't have any more loading > issue, or related basic hangs and it pass BAT for real in all > platofmrs. > > In case BAT is wrong let's first fix BAT before re-enable it here. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96606 > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96526 > Cc: Chris Wilson > Cc: Dave Gordon > Cc: Tvrtko Ursulin > Cc: Stable > Cc: Jani Nikula > Cc: Christophe Prigent > Signed-off-by: Rodrigo Vivi Reverts win, even against silly CI. Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/i915/i915_params.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c > index 8b13bfa..b6e404c 100644 > --- a/drivers/gpu/drm/i915/i915_params.c > +++ b/drivers/gpu/drm/i915/i915_params.c > @@ -54,8 +54,8 @@ struct i915_params i915 __read_mostly = { > .verbose_state_checks = 1, > .nuclear_pageflip = 0, > .edp_vswing = 0, > - .enable_guc_loading = -1, > - .enable_guc_submission = -1, > + .enable_guc_loading = 0, > + .enable_guc_submission = 0, > .guc_log_level = -1, > .enable_dp_mst = true, > .inject_load_failure = 0, > @@ -203,12 +203,12 @@ MODULE_PARM_DESC(edp_vswing, > module_param_named_unsafe(enable_guc_loading, i915.enable_guc_loading, int, 0400); > MODULE_PARM_DESC(enable_guc_loading, > "Enable GuC firmware loading " > - "(-1=auto [default], 0=never, 1=if available, 2=required)"); > + "(-1=auto, 0=never [default], 1=if available, 2=required)"); > > module_param_named_unsafe(enable_guc_submission, i915.enable_guc_submission, int, 0400); > MODULE_PARM_DESC(enable_guc_submission, > "Enable GuC submission " > - "(-1=auto [default], 0=never, 1=if available, 2=required)"); > + "(-1=auto, 0=never [default], 1=if available, 2=required)"); > > module_param_named(guc_log_level, i915.guc_log_level, int, 0400); > MODULE_PARM_DESC(guc_log_level, > -- > 2.5.5 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch