From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com ([74.125.82.68]:32970 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932535AbcG1Qhc (ORCPT ); Thu, 28 Jul 2016 12:37:32 -0400 Received: by mail-wm0-f68.google.com with SMTP id o80so11969311wme.0 for ; Thu, 28 Jul 2016 09:37:32 -0700 (PDT) Date: Thu, 28 Jul 2016 18:37:28 +0200 From: Daniel Vetter To: ville.syrjala@linux.intel.com, Dave Airlie Cc: dri-devel@lists.freedesktop.org, Lyude , Daniel Vetter , stable@vger.kernel.org Subject: Re: [PATCH] drm: aux ->transfer() can return 0, deal with it Message-ID: <20160728163728.GQ6232@phenom.ffwll.local> References: <1469717682-12903-1-git-send-email-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1469717682-12903-1-git-send-email-ville.syrjala@linux.intel.com> Sender: stable-owner@vger.kernel.org List-ID: On Thu, Jul 28, 2016 at 05:54:42PM +0300, ville.syrjala@linux.intel.com wrote: > From: Ville Syrj�l� > > Restore the correct behaviour (as in check msg.reply) when aux > ->transfer() returns 0. It got removed in > commit 82922da39190 ("drm/dp_helper: Retry aux transactions on all errors") > > Now I can actually dump the "entire" DPCD on a Dell UP2314Q with > ddrescue. It has some offsets in the DPCD that can't be read > for some resaon, all you get is defers. Previously ddrescue would > just give up at the first unredable offset on account of > read() returning 0 means EOF. Here's the ddrescue log > for the interested: > 0x00000000 0x00001400 + > 0x00001400 0x00000030 - > 0x00001430 0x000001D0 + > 0x00001600 0x00000030 - > 0x00001630 0x0001F9D0 + > 0x00021000 0x00000001 - > 0x00021001 0x000DEFFF + > > Cc: Lyude > Cc: Daniel Vetter Cc: stable@vger.kernel.org > Fixes: 82922da39190 ("drm/dp_helper: Retry aux transactions on all errors") > Signed-off-by: Ville Syrj�l� Seems to correctly restore that special case. Reviewed-by: Daniel Vetter Dave, since I just send out a drm-misc pull, can you pls apply this one directly to drm-next? -Daniel > --- > drivers/gpu/drm/drm_dp_helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c > index 091053e995e5..8f11b8741e42 100644 > --- a/drivers/gpu/drm/drm_dp_helper.c > +++ b/drivers/gpu/drm/drm_dp_helper.c > @@ -203,7 +203,7 @@ static int drm_dp_dpcd_access(struct drm_dp_aux *aux, u8 request, > > ret = aux->transfer(aux, &msg); > > - if (ret > 0) { > + if (ret >= 0) { > native_reply = msg.reply & DP_AUX_NATIVE_REPLY_MASK; > if (native_reply == DP_AUX_NATIVE_REPLY_ACK) { > if (ret == size) > -- > 2.7.4 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch