From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com ([192.55.52.93]:1631 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756802AbcHCVRi (ORCPT ); Wed, 3 Aug 2016 17:17:38 -0400 Date: Wed, 3 Aug 2016 14:16:45 -0700 From: Matt Roper To: Lyude Cc: intel-gfx@lists.freedesktop.org, Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , Maarten Lankhorst , stable@vger.kernel.org, Daniel Vetter , Radhakrishna Sripada , Hans de Goede , Jani Nikula , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 3/6] drm/i915/skl: Update plane watermarks atomically during plane updates Message-ID: <20160803211645.GB871@intel.com> References: <1470163975-30467-1-git-send-email-cpaul@redhat.com> <1470163975-30467-4-git-send-email-cpaul@redhat.com> <20160802212033.GY32025@intel.com> <20160803211453.GA871@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160803211453.GA871@intel.com> Sender: stable-owner@vger.kernel.org List-ID: On Wed, Aug 03, 2016 at 02:14:53PM -0700, Matt Roper wrote: ... > > I imagine we'll eventually probably want to create a new display vfunc > to handle platform-specific pipe-level stuff that needs to happen under > vblank evasion (like the scalers and linetime WM we have today) to keep > the code clean; maybe add a TODO comment to that effect? > > Anyway, this looks good enough for now, so > > Reviewed-by: Matt Roper Woops, meant to add this reply to your v6 version of the patch obviously... Matt