Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Chris Wilson <chris@chris-wilson.co.uk>,
	intel-gfx@lists.freedesktop.org,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	stable@vger.kernel.org
Subject: Re: [PATCH] drm/i915: Disable stolen on 865G
Date: Thu, 4 Aug 2016 19:44:14 +0300	[thread overview]
Message-ID: <20160804164414.GI4329@intel.com> (raw)
In-Reply-To: <20160804163121.GP6232@phenom.ffwll.local>

On Thu, Aug 04, 2016 at 06:31:21PM +0200, Daniel Vetter wrote:
> On Thu, Aug 04, 2016 at 10:56:04AM +0100, Chris Wilson wrote:
> > It appears our calculation for the address of stolen memory is incorrect
> > for 865G, so for the time being disable our use of that memory.
> > 
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96473
> > Fixes: 0ad98c74e093 ("drm/i915: Deatermine the stolen memory base address...")
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Ville Syrj�l� <ville.syrjala@linux.intel.com>
> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Cc: stable@vger.kernel.org
> 
> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>

There's a potentially better patch (one that actually fixes the stolen
base calculation) attached to the bug.

> > ---
> >  drivers/gpu/drm/i915/i915_gem_stolen.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/gpu/drm/i915/i915_gem_stolen.c b/drivers/gpu/drm/i915/i915_gem_stolen.c
> > index e1791fe96674..8b501ddbc784 100644
> > --- a/drivers/gpu/drm/i915/i915_gem_stolen.c
> > +++ b/drivers/gpu/drm/i915/i915_gem_stolen.c
> > @@ -122,6 +122,7 @@ static unsigned long i915_stolen_to_physical(struct drm_device *dev)
> >  		 * always at TOUD? Ie. is it always the last
> >  		 * one to be allocated by the BIOS?
> >  		 */
> > +		if (0) /* https://bugs.freedesktop.org/show_bug.cgi?id=96473 */
> >  		pci_bus_read_config_word(dev->pdev->bus, PCI_DEVFN(0, 0),
> >  					 I865_TOUD, &toud);
> >  
> > -- 
> > 2.8.1
> > 
> 
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch

-- 
Ville Syrj�l�
Intel OTC

  reply	other threads:[~2016-08-04 16:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-04  9:56 [PATCH] drm/i915: Disable stolen on 865G Chris Wilson
2016-08-04 16:31 ` Daniel Vetter
2016-08-04 16:44   ` Ville Syrjälä [this message]
2016-08-04 16:53     ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160804164414.GI4329@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=daniel.vetter@ffwll.ch \
    --cc=daniel@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox