From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com ([74.125.82.66]:33047 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755305AbcH1Qu2 (ORCPT ); Sun, 28 Aug 2016 12:50:28 -0400 Received: by mail-wm0-f66.google.com with SMTP id o80so6509174wme.0 for ; Sun, 28 Aug 2016 09:50:27 -0700 (PDT) Date: Sun, 28 Aug 2016 18:50:24 +0200 From: Daniel Vetter To: Mario Kleiner , Dave Airlie , Lionel Landwerlin Cc: dri-devel@lists.freedesktop.org, Daniel Vetter , "# v4 . 6+" Subject: Re: [PATCH] drm/atomic: Don't potentially reset color_mgmt_changed on successive property updates. Message-ID: <20160828165024.GA10980@phenom.ffwll.local> References: <1472252548-1722-1-git-send-email-mario.kleiner.de@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1472252548-1722-1-git-send-email-mario.kleiner.de@gmail.com> Sender: stable-owner@vger.kernel.org List-ID: On Sat, Aug 27, 2016 at 01:02:28AM +0200, Mario Kleiner wrote: > Due to assigning the 'replaced' value instead of or'ing it, > if drm_atomic_crtc_set_property() gets called multiple times, > the last call will define the color_mgmt_changed flag, so > a non-updating call to a property can reset the flag and > prevent actual hw state updates required by preceding > property updates. > > Signed-off-by: Mario Kleiner > Cc: Daniel Vetter > Cc: # v4.6+ Fixes: 5488dc16fde7 ("drm: introduce pipe color correction properties") Oops. I wonder why we didn't catch this in testcases ... Reviewed-by: Daniel Vetter Dave, can you pls pick this up? Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch