stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Patch "[PATCH 055/135] lpfc: Fix RDP ACC being too long." has been added to the 4.4-stable tree
@ 2016-09-09 13:38 gregkh
  2016-09-09 14:46 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: gregkh @ 2016-09-09 13:38 UTC (permalink / raw)
  To: james.smart, alexander.levin, dick.kennedy, gregkh, hare,
	martin.petersen
  Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    [PATCH 055/135] lpfc: Fix RDP ACC being too long.

to the 4.4-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     0055-lpfc-Fix-RDP-ACC-being-too-long.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From 73e0304c829778d91116e22f78358d5b2ce07dbd Mon Sep 17 00:00:00 2001
From: James Smart <james.smart@avagotech.com>
Date: Wed, 16 Dec 2015 18:12:00 -0500
Subject: [PATCH 055/135] lpfc: Fix RDP ACC being too long.

[ Upstream commit eb8d68c9930f7f9c8f3f4a6059b051b32077a735 ]

Fix RDP ACC being too long.

Signed-off-by: Dick Kennedy <dick.kennedy@avagotech.com>
Signed-off-by: James Smart <james.smart@avagotech.com>
Reviewed-by: Hannes Reinicke <hare@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/scsi/lpfc/lpfc_els.c |   10 ++++++++++
 1 file changed, 10 insertions(+)

--- a/drivers/scsi/lpfc/lpfc_els.c
+++ b/drivers/scsi/lpfc/lpfc_els.c
@@ -4792,6 +4792,7 @@ lpfc_els_rdp_cmpl(struct lpfc_hba *phba,
 	struct lpfc_nodelist *ndlp = rdp_context->ndlp;
 	struct lpfc_vport *vport = ndlp->vport;
 	struct lpfc_iocbq *elsiocb;
+	struct ulp_bde64 *bpl;
 	IOCB_t *icmd;
 	uint8_t *pcmd;
 	struct ls_rjt *stat;
@@ -4801,6 +4802,8 @@ lpfc_els_rdp_cmpl(struct lpfc_hba *phba,
 
 	if (status != SUCCESS)
 		goto error;
+
+	/* This will change once we know the true size of the RDP payload */
 	cmdsize = sizeof(struct fc_rdp_res_frame);
 
 	elsiocb = lpfc_prep_els_iocb(vport, 0, cmdsize,
@@ -4841,6 +4844,13 @@ lpfc_els_rdp_cmpl(struct lpfc_hba *phba,
 
 	elsiocb->iocb_cmpl = lpfc_cmpl_els_rsp;
 
+	/* Now that we know the true size of the payload, update the BPL */
+	bpl = (struct ulp_bde64 *)
+		(((struct lpfc_dmabuf *)(elsiocb->context3))->virt);
+	bpl->tus.f.bdeSize = (fec_size + RDP_DESC_PAYLOAD_SIZE + 8);
+	bpl->tus.f.bdeFlags = 0;
+	bpl->tus.w = le32_to_cpu(bpl->tus.w);
+
 	phba->fc_stat.elsXmitACC++;
 	rc = lpfc_sli_issue_iocb(phba, LPFC_ELS_RING, elsiocb, 0);
 	if (rc == IOCB_ERROR)


Patches currently in stable-queue which might be from james.smart@avagotech.com are

queue-4.4/0056-lpfc-Fix-mbox-reuse-in-PLOGI-completion.patch
queue-4.4/0052-lpfc-Fix-driver-crash-when-module-parameter-lpfc_fcp.patch
queue-4.4/0121-lpfc-Fix-DMA-faults-observed-upon-plugging-loopback-.patch
queue-4.4/0049-lpfc-Fix-FCF-Infinite-loop-in-lpfc_sli4_fcf_rr_next_.patch
queue-4.4/0055-lpfc-Fix-RDP-ACC-being-too-long.patch
queue-4.4/0051-lpfc-Fix-RegLogin-failed-error-seen-on-Lancer-FC-dur.patch
queue-4.4/0054-lpfc-Fix-RDP-Speed-reporting.patch
queue-4.4/0057-lpfc-Fix-external-loopback-failure.patch
queue-4.4/0053-lpfc-Fix-crash-in-fcp-command-completion-path.patch
queue-4.4/0050-lpfc-Fix-the-FLOGI-discovery-logic-to-comply-with-T1.patch

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Patch "[PATCH 055/135] lpfc: Fix RDP ACC being too long." has been added to the 4.4-stable tree
  2016-09-09 13:38 Patch "[PATCH 055/135] lpfc: Fix RDP ACC being too long." has been added to the 4.4-stable tree gregkh
@ 2016-09-09 14:46 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2016-09-09 14:46 UTC (permalink / raw)
  To: james.smart, alexander.levin, dick.kennedy, hare, martin.petersen
  Cc: stable, stable-commits

Nope, this breaks the build as well, now dropping it...

greg k-h

On Fri, Sep 09, 2016 at 03:38:10PM +0200, gregkh@linuxfoundation.org wrote:
> 
> This is a note to let you know that I've just added the patch titled
> 
>     [PATCH 055/135] lpfc: Fix RDP ACC being too long.
> 
> to the 4.4-stable tree which can be found at:
>     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> 
> The filename of the patch is:
>      0055-lpfc-Fix-RDP-ACC-being-too-long.patch
> and it can be found in the queue-4.4 subdirectory.
> 
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@vger.kernel.org> know about it.
> 
> 
> >From 73e0304c829778d91116e22f78358d5b2ce07dbd Mon Sep 17 00:00:00 2001
> From: James Smart <james.smart@avagotech.com>
> Date: Wed, 16 Dec 2015 18:12:00 -0500
> Subject: [PATCH 055/135] lpfc: Fix RDP ACC being too long.
> 
> [ Upstream commit eb8d68c9930f7f9c8f3f4a6059b051b32077a735 ]
> 
> Fix RDP ACC being too long.
> 
> Signed-off-by: Dick Kennedy <dick.kennedy@avagotech.com>
> Signed-off-by: James Smart <james.smart@avagotech.com>
> Reviewed-by: Hannes Reinicke <hare@suse.de>
> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
> Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>  drivers/scsi/lpfc/lpfc_els.c |   10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> --- a/drivers/scsi/lpfc/lpfc_els.c
> +++ b/drivers/scsi/lpfc/lpfc_els.c
> @@ -4792,6 +4792,7 @@ lpfc_els_rdp_cmpl(struct lpfc_hba *phba,
>  	struct lpfc_nodelist *ndlp = rdp_context->ndlp;
>  	struct lpfc_vport *vport = ndlp->vport;
>  	struct lpfc_iocbq *elsiocb;
> +	struct ulp_bde64 *bpl;
>  	IOCB_t *icmd;
>  	uint8_t *pcmd;
>  	struct ls_rjt *stat;
> @@ -4801,6 +4802,8 @@ lpfc_els_rdp_cmpl(struct lpfc_hba *phba,
>  
>  	if (status != SUCCESS)
>  		goto error;
> +
> +	/* This will change once we know the true size of the RDP payload */
>  	cmdsize = sizeof(struct fc_rdp_res_frame);
>  
>  	elsiocb = lpfc_prep_els_iocb(vport, 0, cmdsize,
> @@ -4841,6 +4844,13 @@ lpfc_els_rdp_cmpl(struct lpfc_hba *phba,
>  
>  	elsiocb->iocb_cmpl = lpfc_cmpl_els_rsp;
>  
> +	/* Now that we know the true size of the payload, update the BPL */
> +	bpl = (struct ulp_bde64 *)
> +		(((struct lpfc_dmabuf *)(elsiocb->context3))->virt);
> +	bpl->tus.f.bdeSize = (fec_size + RDP_DESC_PAYLOAD_SIZE + 8);
> +	bpl->tus.f.bdeFlags = 0;
> +	bpl->tus.w = le32_to_cpu(bpl->tus.w);
> +
>  	phba->fc_stat.elsXmitACC++;
>  	rc = lpfc_sli_issue_iocb(phba, LPFC_ELS_RING, elsiocb, 0);
>  	if (rc == IOCB_ERROR)
> 
> 
> Patches currently in stable-queue which might be from james.smart@avagotech.com are
> 
> queue-4.4/0056-lpfc-Fix-mbox-reuse-in-PLOGI-completion.patch
> queue-4.4/0052-lpfc-Fix-driver-crash-when-module-parameter-lpfc_fcp.patch
> queue-4.4/0121-lpfc-Fix-DMA-faults-observed-upon-plugging-loopback-.patch
> queue-4.4/0049-lpfc-Fix-FCF-Infinite-loop-in-lpfc_sli4_fcf_rr_next_.patch
> queue-4.4/0055-lpfc-Fix-RDP-ACC-being-too-long.patch
> queue-4.4/0051-lpfc-Fix-RegLogin-failed-error-seen-on-Lancer-FC-dur.patch
> queue-4.4/0054-lpfc-Fix-RDP-Speed-reporting.patch
> queue-4.4/0057-lpfc-Fix-external-loopback-failure.patch
> queue-4.4/0053-lpfc-Fix-crash-in-fcp-command-completion-path.patch
> queue-4.4/0050-lpfc-Fix-the-FLOGI-discovery-logic-to-comply-with-T1.patch
> --
> To unsubscribe from this list: send the line "unsubscribe stable" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-09-09 14:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-09 13:38 Patch "[PATCH 055/135] lpfc: Fix RDP ACC being too long." has been added to the 4.4-stable tree gregkh
2016-09-09 14:46 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).