From: Ralf Baechle <ralf@linux-mips.org>
To: Matt Redfearn <matt.redfearn@imgtec.com>
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] MIPS: paravirt: Fix undefined reference to smp_bootstrap
Date: Tue, 13 Sep 2016 16:49:02 +0200 [thread overview]
Message-ID: <20160913144901.GB20655@linux-mips.org> (raw)
In-Reply-To: <1473086620-21007-1-git-send-email-matt.redfearn@imgtec.com>
On Mon, Sep 05, 2016 at 03:43:40PM +0100, Matt Redfearn wrote:
> If the paravirt machine is compiles without CONFIG_SMP, the following
> linker error occurs
>
> arch/mips/kernel/head.o: In function `kernel_entry':
> (.ref.text+0x10): undefined reference to `smp_bootstrap'
>
> due to the kernel entry macro always including SMP startup code.
> Wrap this code in CONFIG_SMP to fix the error.
>
> Signed-off-by: Matt Redfearn <matt.redfearn@imgtec.com>
Thanks, applied. This patch should be applied to 3.16+ also so I've
added a Cc: stable... tag.
Ralf
> arch/mips/include/asm/mach-paravirt/kernel-entry-init.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/mips/include/asm/mach-paravirt/kernel-entry-init.h b/arch/mips/include/asm/mach-paravirt/kernel-entry-init.h
> index 2f82bfa3a773..c9f5769dfc8f 100644
> --- a/arch/mips/include/asm/mach-paravirt/kernel-entry-init.h
> +++ b/arch/mips/include/asm/mach-paravirt/kernel-entry-init.h
> @@ -11,11 +11,13 @@
> #define CP0_EBASE $15, 1
>
> .macro kernel_entry_setup
> +#ifdef CONFIG_SMP
> mfc0 t0, CP0_EBASE
> andi t0, t0, 0x3ff # CPUNum
> beqz t0, 1f
> # CPUs other than zero goto smp_bootstrap
> j smp_bootstrap
> +#endif /* CONFIG_SMP */
>
> 1:
> .endm
> --
> 2.7.4
>
parent reply other threads:[~2016-09-13 14:49 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1473086620-21007-1-git-send-email-matt.redfearn@imgtec.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160913144901.GB20655@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=matt.redfearn@imgtec.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).