From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mail-oi0-f51.google.com ([209.85.218.51]:35539 "EHLO
        mail-oi0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S933343AbcIVP17 (ORCPT
        <rfc822;stable@vger.kernel.org>); Thu, 22 Sep 2016 11:27:59 -0400
Received: by mail-oi0-f51.google.com with SMTP id w11so101642940oia.2
        for <stable@vger.kernel.org>; Thu, 22 Sep 2016 08:27:58 -0700 (PDT)
Date: Thu, 22 Sep 2016 10:27:56 -0500
From: Seth Forshee <seth.forshee@canonical.com>
To: Sachin Prabhu <sprabhu@redhat.com>
Cc: Steve French <sfrench@samba.org>, Aurelien Aptel <aaptel@suse.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org
Subject: Re: cifs mount regression in 4.8 and 4.4 stable
Message-ID: <20160922152756.GB127053@ubuntu-hedt>
References: <20160922150918.GA127053@ubuntu-hedt>
 <1474557429.14139.10.camel@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1474557429.14139.10.camel@redhat.com>
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Thu, Sep 22, 2016 at 04:17:09PM +0100, Sachin Prabhu wrote:
> On Thu, 2016-09-22 at 10:09 -0500, Seth Forshee wrote:
> > We've received reports from users of a cifs mount regression in our
> > 4.4-based kernel, e.g. [1]. It is fixed by reverting the follwing
> > commit
> > from 4.8 which was applied to 4.4 stable:
> > 
> >  a6b5058 fs/cifs: make share unaccessible at root level mountable
> > 
> > Testing against 4.8-rc7 shows that the problem is present there as
> > well.
> > 
> > Thanks,
> > Seth
> > 
> > [1] http://bugs.launchpad.net/bugs/1626112
> 
> Hello Seth, 
> 
> We have identified some regressions introduced by the mentioned patch
> These include

I saw those, but none of the ones already in Linus's tree fix the
problem.

> a) mounting of DFS shares breaks. The fix is included in Steve's tree
> at
> https://git.samba.org/?p=sfrench/cifs-2.6.git;a=commit;h=de5233745cd59c
> f5853d963ad216067788a87594

However this one isn't in Linus's tree yet.

I'm not certain what circumstances cause the failure, but based on what
I see in dmesg it looks likely that this one is the fix. I'll get some
testing with this applied.

Since the broken patch was applied to stable kernels, all of these
kernels need to receive those fixes as well.

Thanks,
Seth