From: Greg KH <greg@kroah.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linaro-kernel@lists.linaro.org,
Build bot for Mark Brown <broonie@kernel.org>,
kernel-build-reports@lists.linaro.org, stable@vger.kernel.org
Subject: Re: v4.4.22 build: 0 failures 4 warnings (v4.4.22)
Date: Sun, 25 Sep 2016 15:21:27 +0200 [thread overview]
Message-ID: <20160925132127.GA12961@kroah.com> (raw)
In-Reply-To: <2634456.rLc29tnUR8@wuerfel>
On Sat, Sep 24, 2016 at 11:29:51PM +0200, Arnd Bergmann wrote:
> On Saturday, September 24, 2016 11:55:27 AM CEST Build bot for Mark Brown wrote:
> >
> > Warnings Summary: 4
> > 3 ../drivers/iio/industrialio-core.c:451:23: warning: format '%u' expects argument of type 'unsigned int', but argument 4 has type 'long int' [-Wformat=]
>
> This was introduced in v4.4.22 with dd1e7b240649 ("iio:core: fix
> IIO_VAL_FRACTIONAL sign handling"), 171c0091837c upstream.
>
> In newer kernels, the type returned from 'abs' is different after
> 8f57e4d930d4 ("include/linux/kernel.h: change abs() macro so it
> uses consistent return type") got applied. We could backport
> that as well into stable, or (simpler) change the format string
> to use "%lu".
I took 8f57e4d930d4 in the queue, thanks, I was trying to figure out
what caused that warning...
>
> > 2 ../kernel/cpuset.c:2101:11: warning: initialization from incompatible pointer type [-Wincompatible-pointer-types]
> > 1 ../kernel/cpuset.c:2101:2: warning: initialization from incompatible pointer type
> > 1 ../kernel/cpuset.c:2101:2: warning: (near initialization for 'cpuset_cgrp_subsys.fork')
>
> This got introduced by 06ec7a1d7646 ("cpuset: make sure new tasks
> conform to the current config of the cpuset"). In the upstream
> kernel, the function prototype was changed as of b53202e63089
> ("cgroup: kill cgrp_ss_priv[CGROUP_CANFORK_COUNT] and friends").
>
> That patch is not suitable for stable kernels, and fortunately
> the warning seems harmless as the prototypes only differ in the
> second argument that is unused. Adding that argument gets rid
> of the warning:
I've applied your patch below to the tree as well, thanks again for both
of these. I'll try to be more careful now that we have all warnings
silent.
Well, most of them, I'm still getting a few odd ones from my build
systems, I'll email a follow-on message going into those...
thanks,
greg k-h
next prev parent reply other threads:[~2016-09-25 13:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-24 10:55 v4.4.22 build: 0 failures 4 warnings (v4.4.22) Build bot for Mark Brown
2016-09-24 21:29 ` Arnd Bergmann
2016-09-25 13:21 ` Greg KH [this message]
2016-09-25 13:21 ` Patch "Fix build warning in kernel/cpuset.c" has been added to the 4.4-stable tree gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160925132127.GA12961@kroah.com \
--to=greg@kroah.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=kernel-build-reports@lists.linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).