v4.4.22 build: 0 failures 4 warnings (v4.4.22)

v4.4.22 build: 0 failures 4 warnings (v4.4.22)

[Build bot for Mark Brown]

Tree/Branch: v4.4.22
Git describe: v4.4.22
Commit: 8d5e93bb8c Linux 4.4.22

Build Time: 71 min 31 sec

Passed:    9 / 9   (100.00 %)
Failed:    0 / 9   (  0.00 %)

Errors: 0
Warnings: 4
Section Mismatches: 0

-------------------------------------------------------------------------------
defconfigs with issues (other than build errors):
      2 warnings    0 mismatches  : arm64-allmodconfig
      1 warnings    0 mismatches  : arm-multi_v7_defconfig
      2 warnings    0 mismatches  : arm-allmodconfig
      2 warnings    0 mismatches  : x86_64-defconfig

-------------------------------------------------------------------------------

Warnings Summary: 4
	  3 ../drivers/iio/industrialio-core.c:451:23: warning: format '%u' expects argument of type 'unsigned int', but argument 4 has type 'long int' [-Wformat=]
	  2 ../kernel/cpuset.c:2101:11: warning: initialization from incompatible pointer type [-Wincompatible-pointer-types]
	  1 ../kernel/cpuset.c:2101:2: warning: initialization from incompatible pointer type
	  1 ../kernel/cpuset.c:2101:2: warning: (near initialization for 'cpuset_cgrp_subsys.fork')



===============================================================================
Detailed per-defconfig build reports below:


-------------------------------------------------------------------------------
arm64-allmodconfig : PASS, 0 errors, 2 warnings, 0 section mismatches

Warnings:
	../kernel/cpuset.c:2101:11: warning: initialization from incompatible pointer type [-Wincompatible-pointer-types]
	../drivers/iio/industrialio-core.c:451:23: warning: format '%u' expects argument of type 'unsigned int', but argument 4 has type 'long int' [-Wformat=]

-------------------------------------------------------------------------------
arm-multi_v7_defconfig : PASS, 0 errors, 1 warnings, 0 section mismatches

Warnings:
	../drivers/iio/industrialio-core.c:451:23: warning: format '%u' expects argument of type 'unsigned int', but argument 4 has type 'long int' [-Wformat=]

-------------------------------------------------------------------------------
arm-allmodconfig : PASS, 0 errors, 2 warnings, 0 section mismatches

Warnings:
	../kernel/cpuset.c:2101:11: warning: initialization from incompatible pointer type [-Wincompatible-pointer-types]
	../drivers/iio/industrialio-core.c:451:23: warning: format '%u' expects argument of type 'unsigned int', but argument 4 has type 'long int' [-Wformat=]

-------------------------------------------------------------------------------
x86_64-defconfig : PASS, 0 errors, 2 warnings, 0 section mismatches

Warnings:
	../kernel/cpuset.c:2101:2: warning: initialization from incompatible pointer type
	../kernel/cpuset.c:2101:2: warning: (near initialization for 'cpuset_cgrp_subsys.fork')
-------------------------------------------------------------------------------

Passed with no errors, warnings or mismatches:

x86_64-allnoconfig
arm64-allnoconfig
arm-allnoconfig
arm-multi_v5_defconfig
arm64-defconfig

Re: v4.4.22 build: 0 failures 4 warnings (v4.4.22)

[Arnd Bergmann]

On Saturday, September 24, 2016 11:55:27 AM CEST Build bot for Mark Brown wrote:
> 
> Warnings Summary: 4
>           3 ../drivers/iio/industrialio-core.c:451:23: warning: format '%u' expects argument of type 'unsigned int', but argument 4 has type 'long int' [-Wformat=]

This was introduced in v4.4.22 with dd1e7b240649 ("iio:core: fix
IIO_VAL_FRACTIONAL sign handling"), 171c0091837c upstream.

In newer kernels, the type returned from 'abs' is different after
8f57e4d930d4 ("include/linux/kernel.h: change abs() macro so it
uses consistent return type") got applied. We could backport
that as well into stable, or (simpler) change the format string
to use "%lu".

>           2 ../kernel/cpuset.c:2101:11: warning: initialization from incompatible pointer type [-Wincompatible-pointer-types]
>           1 ../kernel/cpuset.c:2101:2: warning: initialization from incompatible pointer type
>           1 ../kernel/cpuset.c:2101:2: warning: (near initialization for 'cpuset_cgrp_subsys.fork')

This got introduced by 06ec7a1d7646 ("cpuset: make sure new tasks
conform to the current config of the cpuset"). In the upstream
kernel, the function prototype was changed as of b53202e63089
("cgroup: kill cgrp_ss_priv[CGROUP_CANFORK_COUNT] and friends").

That patch is not suitable for stable kernels, and fortunately
the warning seems harmless as the prototypes only differ in the
second argument that is unused. Adding that argument gets rid
of the warning:

diff --git a/kernel/cpuset.c b/kernel/cpuset.c
index e120bd983ad0..b9279a2844d8 100644
--- a/kernel/cpuset.c
+++ b/kernel/cpuset.c
@@ -2079,7 +2079,7 @@ static void cpuset_bind(struct cgroup_subsys_state *root_css)
  * which could have been changed by cpuset just after it inherits the
  * state from the parent and before it sits on the cgroup's task list.
  */
-void cpuset_fork(struct task_struct *task)
+void cpuset_fork(struct task_struct *task, void *priv)
 {
 	if (task_css_is_root(task, cpuset_cgrp_id))
 		return;



	Arnd

Re: v4.4.22 build: 0 failures 4 warnings (v4.4.22)

[Greg KH]

On Sat, Sep 24, 2016 at 11:29:51PM +0200, Arnd Bergmann wrote:
> On Saturday, September 24, 2016 11:55:27 AM CEST Build bot for Mark Brown wrote:
> > 
> > Warnings Summary: 4
> >           3 ../drivers/iio/industrialio-core.c:451:23: warning: format '%u' expects argument of type 'unsigned int', but argument 4 has type 'long int' [-Wformat=]
> 
> This was introduced in v4.4.22 with dd1e7b240649 ("iio:core: fix
> IIO_VAL_FRACTIONAL sign handling"), 171c0091837c upstream.
> 
> In newer kernels, the type returned from 'abs' is different after
> 8f57e4d930d4 ("include/linux/kernel.h: change abs() macro so it
> uses consistent return type") got applied. We could backport
> that as well into stable, or (simpler) change the format string
> to use "%lu".

I took 8f57e4d930d4 in the queue, thanks, I was trying to figure out
what caused that warning...

> 
> >           2 ../kernel/cpuset.c:2101:11: warning: initialization from incompatible pointer type [-Wincompatible-pointer-types]
> >           1 ../kernel/cpuset.c:2101:2: warning: initialization from incompatible pointer type
> >           1 ../kernel/cpuset.c:2101:2: warning: (near initialization for 'cpuset_cgrp_subsys.fork')
> 
> This got introduced by 06ec7a1d7646 ("cpuset: make sure new tasks
> conform to the current config of the cpuset"). In the upstream
> kernel, the function prototype was changed as of b53202e63089
> ("cgroup: kill cgrp_ss_priv[CGROUP_CANFORK_COUNT] and friends").
> 
> That patch is not suitable for stable kernels, and fortunately
> the warning seems harmless as the prototypes only differ in the
> second argument that is unused. Adding that argument gets rid
> of the warning:

I've applied your patch below to the tree as well, thanks again for both
of these.  I'll try to be more careful now that we have all warnings
silent.

Well, most of them, I'm still getting a few odd ones from my build
systems, I'll email a follow-on message going into those...

thanks,

greg k-h

Patch "Fix build warning in kernel/cpuset.c" has been added to the 4.4-stable tree

[gregkh]

This is a note to let you know that I've just added the patch titled

    Fix build warning in kernel/cpuset.c

to the 4.4-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     fix-build-warning-in-kernel-cpuset.c.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From arnd@arndb.de  Sun Sep 25 15:19:10 2016
From: Arnd Bergmann <arnd@arndb.de>
Date: Sat, 24 Sep 2016 23:29:51 +0200
Subject: Fix build warning in kernel/cpuset.c
To: linaro-kernel@lists.linaro.org
Cc: Build bot for Mark Brown <broonie@kernel.org>, kernel-build-reports@lists.linaro.org, stable@vger.kernel.org
Message-ID: <2634456.rLc29tnUR8@wuerfel>

From: Arnd Bergmann <arnd@arndb.de>


>           2 ../kernel/cpuset.c:2101:11: warning: initialization from incompatible pointer type [-Wincompatible-pointer-types]
>           1 ../kernel/cpuset.c:2101:2: warning: initialization from incompatible pointer type
>           1 ../kernel/cpuset.c:2101:2: warning: (near initialization for 'cpuset_cgrp_subsys.fork')

This got introduced by 06ec7a1d7646 ("cpuset: make sure new tasks
conform to the current config of the cpuset"). In the upstream
kernel, the function prototype was changed as of b53202e63089
("cgroup: kill cgrp_ss_priv[CGROUP_CANFORK_COUNT] and friends").

That patch is not suitable for stable kernels, and fortunately
the warning seems harmless as the prototypes only differ in the
second argument that is unused. Adding that argument gets rid
of the warning:

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 kernel/cpuset.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/kernel/cpuset.c
+++ b/kernel/cpuset.c
@@ -2079,7 +2079,7 @@ static void cpuset_bind(struct cgroup_su
  * which could have been changed by cpuset just after it inherits the
  * state from the parent and before it sits on the cgroup's task list.
  */
-void cpuset_fork(struct task_struct *task)
+void cpuset_fork(struct task_struct *task, void *priv)
 {
 	if (task_css_is_root(task, cpuset_cgrp_id))
 		return;


Patches currently in stable-queue which might be from arnd@arndb.de are

queue-4.4/include-linux-kernel.h-change-abs-macro-so-it-uses-consistent-return-type.patch
queue-4.4/fix-build-warning-in-kernel-cpuset.c.patch