From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com ([217.140.101.70]:51030 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751519AbcI0QMP (ORCPT ); Tue, 27 Sep 2016 12:12:15 -0400 Date: Tue, 27 Sep 2016 17:12:12 +0100 From: Marc Zyngier To: Cc: , , , , , Subject: Re: Patch "hrtimer: Add support for CLOCK_MONOTONIC_RAW" has been added to the 4.4-stable tree Message-ID: <20160927171212.2e75bb99@arm.com> In-Reply-To: <1474986477241162@kroah.com> References: <1474986477241162@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: Greg, On Tue, 27 Sep 2016 16:27:57 +0200 wrote: > This is a note to let you know that I've just added the patch titled > > hrtimer: Add support for CLOCK_MONOTONIC_RAW > > to the 4.4-stable tree which can be found at: > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > > The filename of the patch is: > hrtimer-add-support-for-clock_monotonic_raw.patch > and it can be found in the queue-4.4 subdirectory. > > If you, or anyone else, feels it should not be added to the stable tree, > please let know about it. > > > From 9c808765e88efb6fa6af7e2206ef89512f1840a7 Mon Sep 17 00:00:00 2001 > From: Marc Zyngier > Date: Fri, 15 Jan 2016 17:41:08 +0000 > Subject: hrtimer: Add support for CLOCK_MONOTONIC_RAW > > From: Marc Zyngier > > commit 9c808765e88efb6fa6af7e2206ef89512f1840a7 upstream. > > The KVM/ARM timer implementation arms a hrtimer when a vcpu is > blocked (usually because it is waiting for an interrupt) > while its timer is going to kick in the future. > > It is essential that this timer doesn't get adjusted, or the > guest will end up being woken-up at the wrong time (NTP running > on the host seems to confuse the hell out of some guests). > > In order to allow this, let's add CLOCK_MONOTONIC_RAW support > to hrtimer (it is so far only supported for posix timers). It also > has the (limited) benefit of fixing de0421d53bfb ("mac80211_hwsim: > shuffle code to prepare for dynamic radios"), which already uses > this functionnality without realizing wasn't implemented (just being > lucky...). > > Signed-off-by: Marc Zyngier > Cc: Tomasz Nowicki > Cc: Christoffer Dall > Link: http://lkml.kernel.org/r/1452879670-16133-2-git-send-email-marc.zyngier@arm.com > Signed-off-by: Thomas Gleixner > Cc: Felix Fietkau > Signed-off-by: Greg Kroah-Hartman Please drop that patch. It is utterly broken, and was reverted in mainline with commit 82e88ff1ea94 ("hrtimer: Revert CLOCK_MONOTONIC_RAW support"). Thanks, M. -- Jazz is not dead. It just smells funny.