From: Jakub Kicinski <kubakici@wp.pl>
To: Julia Cartwright <julia@ni.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
Sean Nyekjaer <sean.nyekjaer@prevas.dk>,
Josh Cartwright <joshc@ni.com>,
linux-rt-users@vger.kernel.org, stable@vger.kernel.org,
linux-serial@vger.kernel.org,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: Re: [PATCH] sc16is7xx: Drop bogus use of IRQF_ONESHOT
Date: Thu, 13 Oct 2016 01:48:20 +0100 [thread overview]
Message-ID: <20161013014820.241424bf@laptop> (raw)
In-Reply-To: <20161003151432.17828-1-julia@ni.com>
On Mon, 3 Oct 2016 10:14:32 -0500, Julia Cartwright wrote:
> The use of IRQF_ONESHOT when registering an interrupt handler with
> request_irq() is non-sensical.
> ...
Disabling the irq when kthread is pending as mentioned here:
http://www.spinics.net/lists/linux-rt-users/msg14673.html
could be beneficial but this is definitely a step in the right
direction!
Acked-by: Jakub Kicinski <kubakici@wp.pl>
Thanks a lot Julia!
next prev parent reply other threads:[~2016-10-13 0:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-03 15:14 [PATCH] sc16is7xx: Drop bogus use of IRQF_ONESHOT Julia Cartwright
2016-10-13 0:48 ` Jakub Kicinski [this message]
2016-10-13 15:44 ` [PATCH v2] " Julia Cartwright
[not found] <20160218084634.017c3ab4@laptop>
2016-02-18 17:26 ` [PATCH] sc16is7xx: drop " Josh Cartwright
2016-03-08 12:43 ` Sean Nyekjær
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161013014820.241424bf@laptop \
--to=kubakici@wp.pl \
--cc=bigeasy@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=joshc@ni.com \
--cc=julia@ni.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sean.nyekjaer@prevas.dk \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).