From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 13 Oct 2016 01:48:20 +0100 From: Jakub Kicinski To: Julia Cartwright Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Sean Nyekjaer , Josh Cartwright , linux-rt-users@vger.kernel.org, stable@vger.kernel.org, linux-serial@vger.kernel.org, Sebastian Andrzej Siewior Subject: Re: [PATCH] sc16is7xx: Drop bogus use of IRQF_ONESHOT Message-ID: <20161013014820.241424bf@laptop> In-Reply-To: <20161003151432.17828-1-julia@ni.com> References: <20161003151432.17828-1-julia@ni.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: On Mon, 3 Oct 2016 10:14:32 -0500, Julia Cartwright wrote: > The use of IRQF_ONESHOT when registering an interrupt handler with > request_irq() is non-sensical. > ... Disabling the irq when kthread is pending as mentioned here: http://www.spinics.net/lists/linux-rt-users/msg14673.html could be beneficial but this is definitely a step in the right direction! Acked-by: Jakub Kicinski Thanks a lot Julia!