From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk0-f42.google.com ([209.85.213.42]:35584 "EHLO mail-vk0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932239AbcJMOL5 (ORCPT ); Thu, 13 Oct 2016 10:11:57 -0400 Received: by mail-vk0-f42.google.com with SMTP id q126so26369589vkd.2 for ; Thu, 13 Oct 2016 07:11:42 -0700 (PDT) Date: Thu, 13 Oct 2016 15:11:52 +0200 From: Daniel Vetter To: Joonas Lahtinen Cc: Chris Wilson , intel-gfx@lists.freedesktop.org, stable@vger.kernel.org Subject: Re: [Intel-gfx] [PATCH] drm/i915: Unalias obj->phys_handle and obj->userptr Message-ID: <20161013131152.GN20761@phenom.ffwll.local> References: <20160930173139.24397-1-chris@chris-wilson.co.uk> <1475479083.3067.3.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1475479083.3067.3.camel@linux.intel.com> Sender: stable-owner@vger.kernel.org List-ID: On Mon, Oct 03, 2016 at 10:18:03AM +0300, Joonas Lahtinen wrote: > On pe, 2016-09-30 at 18:31 +0100, Chris Wilson wrote: > > We use obj->phys_handle to choose the pread/pwrite path, but as > > obj->phys_handle is a union with obj->userptr, we then mistakenly use > > the phys_handle path for userptr objects within pread/pwrite. > > > > Testcase: igt/gem_userptr_blits/forbidden-operations > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97519 > > Signed-off-by: Chris Wilson > > Cc: stable@vger.kernel.org > > Reviewed-by: Joonas Lahtinen Commmented already on irc, but I totally panicked about this one. I think we need an ops->pwrite. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch