Re: [PATCH] drm: virtio: reinstate drm_virtio_set_busid()

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Tue, Oct 18, 2016 at 05:52:20PM +0200, Laszlo Ersek wrote:
> On 10/18/16 08:38, Greg Kroah-Hartman wrote:
> > On Mon, Oct 17, 2016 at 11:10:28PM +0200, Laszlo Ersek wrote:
> >> Greg,
> >>
> >> On 10/03/16 19:43, Laszlo Ersek wrote:
> >>> Before commit a325725633c2 ("drm: Lobotomize set_busid nonsense for !pci
> >>> drivers"), several DRM drivers for platform devices used to expose an
> >>> explicit "drm_driver.set_busid" callback, invariably backed by
> >>> drm_platform_set_busid().
> >>>
> >>> Commit a325725633c2 removed drm_platform_set_busid(), along with the
> >>> referring .set_busid field initializations. This was justified because
> >>> interchangeable functionality had been implemented in drm_dev_alloc() /
> >>> drm_dev_init(), which DRM_IOCTL_SET_VERSION would rely on going forward.
> >>>
> >>> However, commit a325725633c2 also removed drm_virtio_set_busid(), for
> >>> which the same consolidation was not appropriate: this .set_busid callback
> >>> had been implemented with drm_pci_set_busid(), and not
> >>> drm_platform_set_busid(). The error regressed Xorg/xserver on QEMU's
> >>> "virtio-vga" card; the drmGetBusid() function from libdrm would no longer
> >>> return stable PCI identifiers like "pci:0000:00:02.0", but rather unstable
> >>> platform ones like "virtio0".
> >>>
> >>> Reinstate drm_virtio_set_busid() with judicious use of
> >>>
> >>>   git checkout -p a325725633c2^ -- drivers/gpu/drm/virtio
> >>>
> >>> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> >>> Cc: Daniel Vetter <daniel.vetter@intel.com>
> >>> Cc: David Airlie <airlied@redhat.com>
> >>> Cc: Emil Velikov <emil.l.velikov@gmail.com>
> >>> Cc: Gerd Hoffmann <kraxel@redhat.com>
> >>> Cc: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> >>> Cc: Hans de Goede <hdegoede@redhat.com>
> >>> Cc: Joachim Frieben <jfrieben@hotmail.com>
> >>> Cc: stable@vger.kernel.org
> >>> Reported-by: Joachim Frieben <jfrieben@hotmail.com>
> >>> Fixes: a325725633c26aa66ab940f762a6b0778edf76c0
> >>> Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1366842
> >>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> >>> Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>
> >>> ---
> >>>  drivers/gpu/drm/virtio/virtgpu_drm_bus.c | 10 ++++++++++
> >>>  drivers/gpu/drm/virtio/virtgpu_drv.c     |  1 +
> >>>  drivers/gpu/drm/virtio/virtgpu_drv.h     |  1 +
> >>>  3 files changed, 12 insertions(+)
> >>
> >> Is there any particular reason this patch hasn't been cherry-picked to
> >> linux-4.8.y? (I checked v4.8.2.)
> > 
> > Yes, it just showed up in 4.9-rc1 3 days ago, give me a chance to catch
> > up!  I have 210 patches right now that are in this same status,
> 
> My apologies; I didn't realize the volume.
> 
> (
> BTW I tried to fetch stable-queue this morning, and just now as well --
> for some reason that git command seems consistently stuck for me. It
> produces some low network traffic, but makes no progress:
> 
> > Looking up git.kernel.org ... done.
> > Connecting to git.kernel.org (port 9418) ... 199.204.44.194 done.
> > <stuck here>
> 
> Should I report this elsewhere and/or capture packets with tcpdump?

Can you clone any other git.kernel.org tree?

Works ok for me here...

thanks,

greg k-h